Google Git
Sign in
chromium / chromium / src / 76a5106072c204a5266bc59c632748083a441018
commit76a5106072c204a5266bc59c632748083a441018[log] [tgz]
authorDaniel White <danieltwhite@google.com>Fri Mar 24 15:53:16 2023
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Fri Mar 24 15:53:16 2023
tree91b61f1a267d4731dbb1c056eb3c225d15a45d60
parentea7e8cc956908ceda56e7d498ee31337a0a09002 [diff]
[iOS] Price Tracking Accessibility Bugs

The price tracking feature was discovered to have three accessibility
bugs. First, the heading text at the top of the Price Tracking Table
View was being labeled as a header by the iOS screen reader. Second, the
link that is embedded into the Trackable Section's subtitle was not
clickable via the screen reader. Lastly, the price drop label was not
being properly read by the screen reader.

In this CL, the first two issues stemmed from the fact that the
TableViewTextHeaderItem class was treating its header and subtitle
labels as one UIAccessibilityElement. The solution was to break up
each label into its own accessibility element. This solution also
worked to remedy the third issue.

Bug: 1427172
Change-Id: Idb153c376c6fc2a9691b5932e2cca4a5011fc258
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4366925
Commit-Queue: Daniel White <danieltwhite@google.com>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1121713}
6 files changed
tree: 91b61f1a267d4731dbb1c056eb3c225d15a45d60
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. weblayer/
  51. .clang-format
  52. .clang-tidy
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .mailmap
  59. .rustfmt.toml
  60. .vpython3
  61. .yapfignore
  62. ATL_OWNERS
  63. AUTHORS
  64. BUILD.gn
  65. CODE_OF_CONDUCT.md
  66. codereview.settings
  67. DEPS
  68. DIR_METADATA
  69. LICENSE
  70. LICENSE.chromium_os
  71. OWNERS
  72. PRESUBMIT.py
  73. PRESUBMIT_test.py
  74. PRESUBMIT_test_mocks.py
  75. README.md
  76. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.