| commit | 76b96062b866ed6a3741df9478a48c049b5906d2 | [log] [tgz] |
|---|---|---|
| author | Julie Jeongeun Kim <jkim@igalia.com> | Thu Apr 04 08:15:59 2024 |
| committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Thu Apr 04 08:15:59 2024 |
| tree | ba4aa5d66ba32e90c8ce89ff0b90164012540b31 | |
| parent | b19c1fd7d428194c6e79f9f9cf3d8468dd179c29 [diff] |
Remove a node that has children if it's fully selected This CL removes a node if it's fully selected, even though it has children on deleting a selection. While handling DeleteSelectionCommand, there is no chance to remove a node itself when it has children, even though it's selected fully. This change checks if the first position of `downstream_end_` anchor node is after `upstream_start_` to know if it's included in the selection. It removes the node, if it is selected from the first position. Bug: 331074432 Change-Id: I2c10904e8bc6b07cc6348449cf62b0cc71251f4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5404456 Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Julie Jeongeun Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/main@{#1282356}
ChromiumChromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.