Google Git
Sign in
chromium / chromium / src / 76d783f0855810dd5a91da59831e0054828a1fdd
commit76d783f0855810dd5a91da59831e0054828a1fdd[log] [tgz]
authorDarren Shen <shend@chromium.org>Wed Jun 23 04:27:32 2021
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Wed Jun 23 04:27:32 2021
treeefc40c9d7e5eb65ad307ddb8445c64b9cdcd912e
parent6a666ba529bef837711b0c7f00a8647f42580c2c [diff]
ime: Move UTF normalization code into IMEs.

Unicode codepoints can be encoded in various normalization schemes.
We currently normalize the output of our IMEs via
NativeInputMethodEngine.

However, normalization may affect the length and indices of the string.
Therefore, if an IME calls a function with an unnormalized string and
an index into that unnormalized string, the index may become invalid.

Therefore, the IME must do all the normalization itself rather than
NativeInputMethodEngine doing it. Otherwise, NativeInputMethodEngine
will need to adjust indices and offsets after normalization.

BUG=1194372

Change-Id: I2322e2883fb540419aa7a3dc4095364735bdb48b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2976480
Reviewed-by: Jing Wang <jiwan@chromium.org>
Commit-Queue: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#895011}
3 files changed
tree: efc40c9d7e5eb65ad307ddb8445c64b9cdcd912e
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. codelabs/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. jingle/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. weblayer/
  53. .clang-format
  54. .clang-tidy
  55. .eslintrc.js
  56. .git-blame-ignore-revs
  57. .gitattributes
  58. .gitignore
  59. .gn
  60. .mailmap
  61. .vpython
  62. .vpython3
  63. .yapfignore
  64. AUTHORS
  65. BUILD.gn
  66. CODE_OF_CONDUCT.md
  67. codereview.settings
  68. DEPS
  69. DIR_METADATA
  70. ENG_REVIEW_OWNERS
  71. LICENSE
  72. LICENSE.chromium_os
  73. OWNERS
  74. PRESUBMIT.py
  75. PRESUBMIT_test.py
  76. PRESUBMIT_test_mocks.py
  77. README.md
  78. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.