[TabGroupsSync] Cache id mapping to preserve saved state of tab groups

This CL caches the TabGroupId to Saved GUID mapping on browser startup
in order to preserve the saved state of a tab group before the
TabGroupSyncService has initialized.

This prevents duplicate groups from being created when we restart or
crash on startup after the tab group is restored into the browser
but before we connect the tab group to the saved group in
TabGroupSyncService.

Approach:
- On browser startup when RestoreTabGroupMetadata is called cache the
TabGroupId to Saved GUID mapping into SessionService
- When SetTabGroupMetadata is called pull the saved GUID from TGSS if
it's available, otherwise get the id mapping from the cache.
- Write the preserved state to the disk.

Changes:
- Consolidates the retrieval of saved_guid into
SessionService::SetTabGroupMetadata
- Removes the saved_guid parameter from SetTabGroupMetadata since it is
no longer needed
- Adds a mapping for TabGroupId to saved guid string into SessionService
- Updates all callsites of SetTabGroupMetadata to no longer pass in saved_guid
- Removes saved tab group dependency from browser.cc!

Test updated in: chrome/browser/sessions/session_service_unittest.cc

Change-Id: I8a496b2c9992bb525de8aadd1534782e991a0ef5
Bug: 365519965
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5961164
Commit-Queue: Darryl James <dljames@chromium.org>
Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com>
Reviewed-by: Eshwar Stalin <estalin@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1375006}
6 files changed
tree: d67beb41f56fb8a9f17d3307ac58983d01fac948
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. crypto/
  16. dbus/
  17. device/
  18. docs/
  19. extensions/
  20. fuchsia_web/
  21. gin/
  22. google_apis/
  23. gpu/
  24. headless/
  25. infra/
  26. ios/
  27. ipc/
  28. media/
  29. mojo/
  30. native_client_sdk/
  31. net/
  32. pdf/
  33. ppapi/
  34. printing/
  35. remoting/
  36. rlz/
  37. sandbox/
  38. services/
  39. skia/
  40. sql/
  41. storage/
  42. styleguide/
  43. testing/
  44. third_party/
  45. tools/
  46. ui/
  47. url/
  48. webkit/
  49. .clang-format
  50. .clang-tidy
  51. .clangd
  52. .git-blame-ignore-revs
  53. .gitallowed
  54. .gitattributes
  55. .gitignore
  56. .gitmodules
  57. .gn
  58. .mailmap
  59. .rustfmt.toml
  60. .vpython3
  61. .yapfignore
  62. ATL_OWNERS
  63. AUTHORS
  64. BUILD.gn
  65. CODE_OF_CONDUCT.md
  66. codereview.settings
  67. CPPLINT.cfg
  68. CRYPTO_OWNERS
  69. DEPS
  70. DIR_METADATA
  71. LICENSE
  72. LICENSE.chromium_os
  73. OWNERS
  74. PRESUBMIT.py
  75. PRESUBMIT_test.py
  76. PRESUBMIT_test_mocks.py
  77. README.md
  78. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.