Google Git
Sign in
chromium / chromium / src / 7778198165833ef0890951838a87e31498637048
commit7778198165833ef0890951838a87e31498637048[log] [tgz]
authorMunira Tursunova <moonira@google.com>Mon Jan 08 14:11:54 2024
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Mon Jan 08 14:11:54 2024
tree3a2752729bc6b68601c901eb9231422b99e3d4bf
parent671d8622bf5e6c7cfa5be357b642fd3e54433e23 [diff]
Fix crash in font_matcher_mac.mm

Add check to null before getting the CFNumber values from attributes
dictionary in BestStyleMatchForFamily and GetAlternateFontPlatformData.

The crash seems to appear only when the client has custom installed
fonts on the system that returns nullptr when asked for weight value
by CoreText. Failed to reproduce the crash with font that has invalid
`usWeightClass` value and the font that does not have OS/2 table.

Considering above and the fact that there are no pre-installed system
fonts that can cause this issue, it is not possible to create a
reproduction test.

Bug: 318593063
Change-Id: I9c309dad6712b741c0ed9fdad66dc21acd2aa9c6
Cq-Include-Trybots: luci.chromium.try:mac13.arm64-blink-rel,mac13-blink-rel,mac12.0-blink-rel,mac12.0.arm64-blink-rel,mac11.0-blink-rel,mac11.0.arm64-blink-rel,mac10.15-blink-rel
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5168607
Reviewed-by: Dominik Röttsches <drott@chromium.org>
Commit-Queue: Munira Tursunova <moonira@google.com>
Cr-Commit-Position: refs/heads/main@{#1244028}
2 files changed
tree: 3a2752729bc6b68601c901eb9231422b99e3d4bf
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. webkit/
  51. clank
  52. internal
  53. ios_internal
  54. native_client
  55. signing_keys
  56. v8
  57. .clang-format
  58. .clang-tidy
  59. .clangd
  60. .eslintrc.js
  61. .git-blame-ignore-revs
  62. .gitattributes
  63. .gitignore
  64. .gitmodules
  65. .gn
  66. .mailmap
  67. .rustfmt.toml
  68. .vpython3
  69. .yapfignore
  70. ATL_OWNERS
  71. AUTHORS
  72. BUILD.gn
  73. CODE_OF_CONDUCT.md
  74. codereview.settings
  75. DEPS
  76. DIR_METADATA
  77. LICENSE
  78. LICENSE.chromium_os
  79. OWNERS
  80. PRESUBMIT.py
  81. PRESUBMIT_test.py
  82. PRESUBMIT_test_mocks.py
  83. README.md
  84. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.