Google Git
Sign in
chromium / chromium / src / 77f295ad14035dcdc5aa83305509e22679057c24
commit77f295ad14035dcdc5aa83305509e22679057c24[log] [tgz]
authorcassycc <cassycc@google.com>Fri Feb 16 01:07:46 2024
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Fri Feb 16 01:07:46 2024
treee5e18d1c64abdbb60f0291c8a69a070d6d42a298
parentfc32a2390536e236654a750a664733594df5f187 [diff]
[Office upload] Use SetupOrMoveDialogPage enum to create dialog args

The DialogPage enum was always confusing as it contained pages for the
setup flow and move confirmation, which are handled together, and the
connect to OneDrive page, which is handled completely separately.

Since http://crrev.com/c/4853720 landed, the connect to OneDrive page
enum has become completely unused. It is best to remove it from the
DialogPage enum so it's not confusing when only setup flow and move
confirmation pages are being handled. Rename the DialogPage enum to
SetupOrMoveDialogPage to make to extra clear.

Bug: None
Change-Id: I4268f59ef7ca1c17651c336bc842104f5a7b6427
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5298491
Reviewed-by: Peter Marshall <petermarshall@chromium.org>
Commit-Queue: Cassy Chun-Crogan <cassycc@google.com>
Cr-Commit-Position: refs/heads/main@{#1261429}
3 files changed
tree: e5e18d1c64abdbb60f0291c8a69a070d6d42a298
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. webkit/
  51. clank
  52. internal
  53. ios_internal
  54. native_client
  55. signing_keys
  56. v8
  57. .clang-format
  58. .clang-tidy
  59. .clangd
  60. .eslintrc.js
  61. .git-blame-ignore-revs
  62. .gitallowed
  63. .gitattributes
  64. .gitignore
  65. .gitmodules
  66. .gn
  67. .mailmap
  68. .rustfmt.toml
  69. .vpython3
  70. .yapfignore
  71. ATL_OWNERS
  72. AUTHORS
  73. BUILD.gn
  74. CODE_OF_CONDUCT.md
  75. codereview.settings
  76. DEPS
  77. DIR_METADATA
  78. LICENSE
  79. LICENSE.chromium_os
  80. OWNERS
  81. PRESUBMIT.py
  82. PRESUBMIT_test.py
  83. PRESUBMIT_test_mocks.py
  84. README.md
  85. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.