commit | 786f5369dbd44af8fee4bdb10c5b88bd7d725a92 | [log] [tgz] |
---|---|---|
author | Gyuyoung Kim <gyuyoung@igalia.com> | Thu Feb 28 01:48:35 2019 |
committer | Commit Bot <commit-bot@chromium.org> | Thu Feb 28 01:48:35 2019 |
tree | b011328ed77812acc5b7631942c809cfe6e1ade0 | |
parent | ba9748e78ec7e9c0d594e7edf7b2c07ea2a90449 [diff] |
BlinkMemoryMgt: Annotate Blink's platform/bindings with the macros of Allocator The OnionSoup effort has a goal of allocating all garbage-collectible Blink objects with Oilpan or PartitionAlloc. However, some classes of //blink/renderer/platform/bindings have not yet been allocated with them so far. So their uses of non-garbage-collected objects should be restricted to cases where the garbage collector can discover their references. The macros of Allocator will be useful for the non-garbage-collected objects to avoid unintended allocations. After some analyzes, it was concluded that for the case of RuntimeCallCounter, RuntimeCallTimer, and RuntimeCallStats classes, it makes sense to use USING_FAST_MALLOC because it has been used with smart pointers. In ParkableString and MarkingDequeItem classes case, it makes sense to use DISALLOW_NEW because it's used by a member variable as a reference type. Lastly, the rest of platform/bindings make sense to use STACK_ALLOCATED() because they have been used by function inside. Bug: 919389 Change-Id: Idbd7b45195c30ac542e18d426da50cf76ef2a25b Reviewed-on: https://chromium-review.googlesource.com/c/1491166 Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#636252}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .