Google Git
Sign in
chromium / chromium / src / 78727d6b354ab03cc27580cfbabb494b142de594
commit78727d6b354ab03cc27580cfbabb494b142de594[log] [tgz]
authorMichael Checo <michaelcheco@google.com>Sat Jan 07 00:12:13 2023
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Sat Jan 07 00:12:13 2023
tree4d3c2ff3d45f685c96e20b0c75526dd29ae622e8
parent6b675f8e09674d251734f4770a40d20b453a1ef8 [diff]
shortcuts: Support standard accelerators in Ambient map

- Our NonConfigurableActions enum contains both Browser and Ambient
  action ids. Browser actions normally map to standard accelerators
  which means our details map now needs to support storing a list
  of accelerators for a given Browser action id

Steps to adding a standard non-configurable accelerator:
1. Add the action to the accelerator layout table
2. Add the <action, list of accelerators> to the NonConfigurableActionsMap.

Bug: b:216049298
Test: ash_webui_unittests AcceleratorConfigurationProviderTest
Change-Id: I95848c52fc535addfcc5d3c9451b223bf15e81f5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4134796
Reviewed-by: Jimmy Gong <jimmyxgong@chromium.org>
Commit-Queue: Michael Checo <michaelcheco@google.com>
Cr-Commit-Position: refs/heads/main@{#1089966}
5 files changed
tree: 4d3c2ff3d45f685c96e20b0c75526dd29ae622e8
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. weblayer/
  51. .clang-format
  52. .clang-tidy
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .mailmap
  59. .rustfmt.toml
  60. .vpython3
  61. .yapfignore
  62. ATL_OWNERS
  63. AUTHORS
  64. BUILD.gn
  65. CODE_OF_CONDUCT.md
  66. codereview.settings
  67. DEPS
  68. DIR_METADATA
  69. LICENSE
  70. LICENSE.chromium_os
  71. OWNERS
  72. PRESUBMIT.py
  73. PRESUBMIT_test.py
  74. PRESUBMIT_test_mocks.py
  75. README.md
  76. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.