Google Git
Sign in
chromium / chromium / src / 7876fb1ce48533ae5ac732b4f3197979c9905e36
commit7876fb1ce48533ae5ac732b4f3197979c9905e36[log] [tgz]
authorSam Zackrisson <saza@chromium.org>Tue Nov 02 14:20:35 2021
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Tue Nov 02 14:20:35 2021
tree499eee75d2fdf7e5ed991248b5b7cfdad34d6a56
parent4412205951bd62e8a529abd249b3002c24916dcc [diff]
Move analog mic level transformations into MediaStreamAudioProcessor

The WebRtcAudioDeviceImpl microphone volume code is also removed, because it is unused: Audio processing runs outside of WebRTC.

These changes are not necessary for running APM (webrtc::AudioProcessing) in the audio process, but it makes the associated code a little more straightforward:
- dead code is removed (volume passing in WebRtcAudioDeviceImpl and ProcessedLocalAudioSource).
- an atomic is removed.
- the integer format for analog gain levels is isolated to the code interacting with APM, in MediaStreamAudioProcessor, and becomes easier to share between APM in the renderer and (future) APM in the audio process.

Bug: chromium:1215061
Change-Id: I298c3f631dba84f3d6624128dc5839faad704107
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3251174
Reviewed-by: Alessio Bazzica <alessiob@chromium.org>
Reviewed-by: Henrik Boström <hbos@chromium.org>
Reviewed-by: Henrik Andreasson <henrika@chromium.org>
Reviewed-by: Olga Sharonova <olka@chromium.org>
Commit-Queue: Sam Zackrisson <saza@chromium.org>
Cr-Commit-Position: refs/heads/main@{#937324}
10 files changed
tree: 499eee75d2fdf7e5ed991248b5b7cfdad34d6a56
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. codelabs/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. jingle/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. weblayer/
  53. .clang-format
  54. .clang-tidy
  55. .eslintrc.js
  56. .git-blame-ignore-revs
  57. .gitattributes
  58. .gitignore
  59. .gn
  60. .mailmap
  61. .rustfmt.toml
  62. .vpython
  63. .vpython3
  64. .yapfignore
  65. AUTHORS
  66. BUILD.gn
  67. CODE_OF_CONDUCT.md
  68. codereview.settings
  69. DEPS
  70. DIR_METADATA
  71. ENG_REVIEW_OWNERS
  72. LICENSE
  73. LICENSE.chromium_os
  74. OWNERS
  75. PRESUBMIT.py
  76. PRESUBMIT_test.py
  77. PRESUBMIT_test_mocks.py
  78. README.md
  79. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.