Google Git
Sign in
chromium / chromium / src / 78861c88a33439e94173bca65e4628cfbb70f07e
commit78861c88a33439e94173bca65e4628cfbb70f07e[log] [tgz]
authorAna Sollano Kim <ansollan@microsoft.com>Wed Nov 06 00:58:25 2024
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Wed Nov 06 00:58:25 2024
tree455b53cc47953457a9c158644d17645bc543c04c
parentc87ce69c9b245030c46be0a5215eba084dd249a8 [diff]
Scope <select> mutation observer to size==1, non-multiple <select>s, and element attachment

Currently, we use the mutation observer to check for changes in all <select>s' descendants and then check if those added nodes are allowed according to the content model. However, this caused a performance regression so in this CL the mutation observer is scoped to attached <select>s size==1 and non-multiple. Additionally, console errors are only logged for customizable <select>s.

Rebaselined tests containing a <select> that no longer needs the console warning, added two new performance tests for customizable <select>s.

Bug: 370735374
Change-Id: I58f704e842b499d261c1a1945802fc27431cd408
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5905527
Commit-Queue: Ana Sollano Kim <ansollan@microsoft.com>
Reviewed-by: Joey Arhar <jarhar@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1378685}
28 files changed
tree: 455b53cc47953457a9c158644d17645bc543c04c
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. crypto/
  16. dbus/
  17. device/
  18. docs/
  19. extensions/
  20. fuchsia_web/
  21. gin/
  22. google_apis/
  23. gpu/
  24. headless/
  25. infra/
  26. ios/
  27. ipc/
  28. media/
  29. mojo/
  30. native_client_sdk/
  31. net/
  32. pdf/
  33. ppapi/
  34. printing/
  35. remoting/
  36. rlz/
  37. sandbox/
  38. services/
  39. skia/
  40. sql/
  41. storage/
  42. styleguide/
  43. testing/
  44. third_party/
  45. tools/
  46. ui/
  47. url/
  48. webkit/
  49. clank
  50. internal
  51. ios_internal
  52. native_client
  53. signing_keys
  54. v8
  55. .clang-format
  56. .clang-tidy
  57. .clangd
  58. .git-blame-ignore-revs
  59. .gitallowed
  60. .gitattributes
  61. .gitignore
  62. .gitmodules
  63. .gn
  64. .mailmap
  65. .rustfmt.toml
  66. .vpython3
  67. .yapfignore
  68. ATL_OWNERS
  69. AUTHORS
  70. BUILD.gn
  71. CODE_OF_CONDUCT.md
  72. codereview.settings
  73. CPPLINT.cfg
  74. CRYPTO_OWNERS
  75. DEPS
  76. DIR_METADATA
  77. LICENSE
  78. LICENSE.chromium_os
  79. OWNERS
  80. PRESUBMIT.py
  81. PRESUBMIT_test.py
  82. PRESUBMIT_test_mocks.py
  83. README.md
  84. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.