commit | 78a3cebbb7d464c2fa0d3148f36b9af4018e62b0 | [log] [tgz] |
---|---|---|
author | Takashi Sakamoto <tasak@google.com> | Tue Feb 19 08:17:11 2019 |
committer | Commit Bot <commit-bot@chromium.org> | Tue Feb 19 08:17:11 2019 |
tree | caf3c30ee0cd387572c7a293ddb543c9def99367 | |
parent | 9b90992e3815ea749f7fa1dd90f6822aecc1c4ef [diff] |
Revert "Streams: Prevent double-resolution of promises" This reverts commit e2fc2d69f4b5593fc184a25ffcea0c1f66701839. Reason for revert: Suspect blink_unittests failures on LinuxTests(dbg)(32), LinuxTests(dbg), Mac10.13Tests(dbg) failures: ReadableStreamOperationsTest.Tee ReadableStreamBytesConsumerTest.Create WritableStreamTest.CreateWithoutArguments .. After reverting this patch, I will monitor the bots. If the tests are still failing on the bots, I will revert the revert patch. Original change's description: > Streams: Prevent double-resolution of promises > > The v8.resolvePromise() and v8.rejectPromise() do not make > double-resolution of promises a no-op like the JavaScript APIs do. Add > protection against resolving or rejecting the same promise twice. > > Attach a new internal symbol "_isSettled" to a promise when it is > resolved or rejected inside the resolvePromise() and rejectPromise() > functions. If the symbol is already present, the promise has already > been resolved or rejected and so do nothing. > > BUG=931953 > > Change-Id: Icd6ee6e3ea3e5843087af13ed051d45976e5364c > Reviewed-on: https://chromium-review.googlesource.com/c/1475591 > Reviewed-by: Yutaka Hirano <yhirano@chromium.org> > Commit-Queue: Adam Rice <ricea@chromium.org> > Cr-Commit-Position: refs/heads/master@{#633190} TBR=ricea@chromium.org,yhirano@chromium.org Change-Id: Ie11dd5b1ba6eea4caf7a47cf36e364068abe33e1 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 931953 Reviewed-on: https://chromium-review.googlesource.com/c/1477462 Reviewed-by: Takashi Sakamoto <tasak@google.com> Commit-Queue: Takashi Sakamoto <tasak@google.com> Cr-Commit-Position: refs/heads/master@{#633212}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .