commit | 78b443c43754c16a5a0238b3157326ab27fa9064 | [log] [tgz] |
---|---|---|
author | Lu Huang <luhua@microsoft.com> | Wed Nov 24 21:33:05 2021 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Wed Nov 24 21:33:05 2021 |
tree | 2ccb7ca2d59654017cedf45f6daa8fd1ff9d2a29 | |
parent | 2a6037673bc32e2abe281d610341b82990b1b552 [diff] |
Check WebAppProvider is available before adding UrlHandlersHandler WebAppProvider may not be available on some platforms. Constructing UrlHandlersHandler would cause a null dereference error if WebAppProvider is not available. Document that describes the original WebUI page design that makes use UrlHandlersHandler: https://docs.google.com/document/d/1pL9VexY86o3YW-iP1iN_O2fzj9QBqvBQm7CWMl5Djf0/edit?usp=sharing cl/3271675 and cl/3230019 are similar cls that check for WebAppProvider. Bug: 1217423, 1072058 Change-Id: I87a5a561453fda45bdd0af91b267672c8e253df9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3274554 Reviewed-by: dpapad <dpapad@chromium.org> Commit-Queue: Lu Huang <luhua@microsoft.com> Cr-Commit-Position: refs/heads/main@{#945118}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.