Google Git
Sign in
chromium / chromium / src / 78c6bfaa1f457f42e9d69bd6a5c1621a6ad5d4c3
commit78c6bfaa1f457f42e9d69bd6a5c1621a6ad5d4c3[log] [tgz]
authorEd Chin <edchin@google.com>Wed Jul 27 13:48:53 2022
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Wed Jul 27 13:48:53 2022
treec784d9023de2e8f8cf40675a46172d76ce420e88
parent25fd463da4e06bbeaca5e3e5bf96ab18ff7eb735 [diff]
[ios][feed] Move DiscoverFeedService creation from InitStageFinal to InitStageNormalUI.

** This has nothing to do with background refresh **

We moved DiscoverFeedService creation from SceneController to
an AppAgent in crrev.com/c/3752061. However, we inadvertently
changed the init stage where it happens from InitStageNormalUI
to InitStageFinal in that CL. This CL corrects that mistake. However,
I do not think that InitStageFinal caused an issue.

This CL also removes the no-op when the browserState is nullptr. It
is expected to be available, and therefore should crash in that case.

Change-Id: I63e5a69dfe0e062214823986511a88362e0417a1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3784255
Commit-Queue: edchin <edchin@google.com>
Reviewed-by: Vincent Boisselle <vincb@google.com>
Reviewed-by: Tina Wang <tinazwang@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1028709}
1 file changed
tree: c784d9023de2e8f8cf40675a46172d76ce420e88
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. weblayer/
  51. .clang-format
  52. .clang-tidy
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .mailmap
  59. .rustfmt.toml
  60. .vpython
  61. .vpython3
  62. .yapfignore
  63. AUTHORS
  64. BUILD.gn
  65. CODE_OF_CONDUCT.md
  66. codereview.settings
  67. DEPS
  68. DIR_METADATA
  69. ENG_REVIEW_OWNERS
  70. LICENSE
  71. LICENSE.chromium_os
  72. OWNERS
  73. PRESUBMIT.py
  74. PRESUBMIT_test.py
  75. PRESUBMIT_test_mocks.py
  76. README.md
  77. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.