commit | 78c7082ce13cb03c178c0bacbf79ca5ae98d8a05 | [log] [tgz] |
---|---|---|
author | Mike Dougherty <michaeldo@chromium.org> | Fri May 16 16:11:38 2025 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Fri May 16 16:11:38 2025 |
tree | b6cc34ad7184b0d33a051839580bf89d900f9c11 | |
parent | 375cb028ee3060123897ab9dd788be5ae7a7e516 [diff] |
Revert "Allow to mock multiple protocol in a single object" This reverts commit bd5088ff3395df7935f7bee65304c429c004c256. Reason for revert: Speculative revert for failing HistoryUITestCase/* Original change's description: > Allow to mock multiple protocol in a single object > > An Objective-C object can naturally implements an arbitrary number of > protocol. I ended up in a case where I had to modify my code, because > an object was expected to implement two protocols and OCMock does not > allow it. I’d love to see this code merged so that it can. > > I also edited the code for nice mocks in order for the API to be > consistent. I don’t actually need it. > > It should be noted that the description is not changed in the case > where there is a single protocol mocked. > > Change-Id: I99f7c8f40041291d3eb1f8075334fa88bec60068 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6494931 > Auto-Submit: Arthur Milchior <arthurmilchior@chromium.org> > Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> > Reviewed-by: Marijn Kruisselbrink <mek@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1460973} Change-Id: I79681e66dca6d2b404fb23d2b0c80b35529d62e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6556722 Owners-Override: Mike Dougherty <michaeldo@chromium.org> Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1461405}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.