commit 78d611582e176735c229965589cbb837bf08dc2a
author Dominik Inführ <dinfuehr@google.com> Tue Jul 24 13:55:55 2018
committer Commit Bot <commit-bot@chromium.org> Tue Jul 24 13:55:55 2018
tree 3e7b57c395fffec3738c18fec6e93d86b11d7b34
parent 6cd75c790ea9b2f25ec4c0d72ad69a5a299c7afe

DevTools: no link when snapshot loaded from file

Code failed when snapshot was not taken from the running application but
loaded from file. heapProfilerModel() returns null if snapshot was loaded
from file.

Bug: chromium:854097
Change-Id: I3c269a78f7f8ec59a15f510dda6ab55a72f53616
Reviewed-on: https://chromium-review.googlesource.com/1146921
Commit-Queue: Dominik Inführ <dinfuehr@google.com>
Reviewed-by: Alexei Filippov <alph@chromium.org>
Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577515}

third_party/blink/renderer/devtools/front_end/profiler/HeapSnapshotView.js

diff --git a/third_party/blink/renderer/devtools/front_end/profiler/HeapSnapshotView.js b/third_party/blink/renderer/devtools/front_end/profiler/HeapSnapshotView.js
index 57bf5fb7..b020a21 100644
--- a/third_party/blink/renderer/devtools/front_end/profiler/HeapSnapshotView.js
+++ b/third_party/blink/renderer/devtools/front_end/profiler/HeapSnapshotView.js
@@ -209,6 +209,9 @@
    */
   async linkifyObject(snapshotObjectId) {
     const heapProfilerModel = this._profile.heapProfilerModel();
+    // heapProfilerModel is null if snapshot was loaded from file
+    if (!heapProfilerModel)
+      return null;
     const remoteObject = await heapProfilerModel.objectForSnapshotObjectId(String(snapshotObjectId), 'link');
     if (!remoteObject || remoteObject.type !== 'function')
       return null;