commit 78da0d1d7de11f0a8631479814a17e3ce5fb5945
author Sirisha Kavuluru <skavuluru@google.com> Sat Nov 16 03:42:25 2024
committer Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> Sat Nov 16 03:42:25 2024
tree 3091c242688a8a572b035e0985e736f4ede85cd0
parent eb22082774b1813c97cabc5f050504959f503dd4

[Toolbar] Remove layoutLocationBar() call from setTabSwitcherMode()

Context: layoutLocationBar() call was added as part of crbug.com/518795 to update the location bar when the tab switcher button is clicked while urlBar expansion is in progress.

This call is now not being invoked in the tab switcher enter flow. We make the tab switcher button not clickable before starting expansion animation [1]. Made the button clickable and slowed down animation to test and the call is still not invoked.

When the tab switcher button is clicked, onUrlFocusChanged(false) is invoked first - we end the running animation here for unfocus [2] and call updateLocationBarLayoutForExpansionAnimation which updates the location bar state for unfocus. Then setTabSwitcherMode() is invoked which calls layoutLocationBar() only when animations are running [3] which is not true anymore.

Intention of removing this call: This method calls updateLocationBarLayoutForExpansionAnimation() which is also called from updateUrlExpansionAnimation(). We want to refactor out updateUrlExpansionAnimation() to a separate class along with updateLocationBarLayoutForExpansionAnimation(). Removing the only other caller helps with this refactor.

[1] https://source.chromium.org/chromium/chromium/src/+/main:chrome/browser/ui/android/toolbar/java/src/org/chromium/chrome/browser/toolbar/top/ToolbarPhone.java;l=2058;drc=60130be50f68c89220d8ace62c87155025267a2c?q=Toolbarphone
[2] https://source.chromium.org/chromium/chromium/src/+/main:chrome/browser/ui/android/toolbar/java/src/org/chromium/chrome/browser/toolbar/top/ToolbarPhone.java;l=2158-2161;drc=60130be50f68c89220d8ace62c87155025267a2c?q=Toolbarphone
[3] https://source.chromium.org/chromium/chromium/src/+/main:chrome/browser/ui/android/toolbar/java/src/org/chromium/chrome/browser/toolbar/top/ToolbarPhone.java;l=1887-1894;drc=60130be50f68c89220d8ace62c87155025267a2c?q=Toolbarphone

Bug: 355074249
Change-Id: Id0dfa6a0cdcc0012839f3118114b8e8a9d5b8cb2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5868154
Reviewed-by: Theresa Sullivan <twellington@chromium.org>
Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com>
Commit-Queue: Sirisha Kavuluru <skavuluru@google.com>
Cr-Commit-Position: refs/heads/main@{#1383956}