Google Git
Sign in
chromium / chromium / src / 88311578aee94fc2d2f579b771646c9e63df629f
commit88311578aee94fc2d2f579b771646c9e63df629f[log] [tgz]
authorNick Burris <nburris@chromium.org>Thu May 23 21:52:45 2019
committerCommit Bot <commit-bot@chromium.org>Thu May 23 21:52:45 2019
tree18a88a495f88659867f79b90630f1cdfc823aa14
parent1f8404dc0e6f2c2d75fec0bf0dac9b48565ecaa4 [diff]
Make Android scrollbars not hit testable

Android scrollbars can't be interacted with by user input. This change
makes the SolidColorScrollbarLayer explicitly not hit testable to
ensure we don't enter any scrollbar scrolling code paths.

Also updated a few tests in layer_tree_host_impl_unittest.cc that were
using a SolidColorScrollbarLayer as a generic (hit-testable) scrollbar
layer, which should instead use a PaintedScrollbarLayer.

Bug: 954366
Change-Id: Icae9f43e043c412603d30330386710bf59482fad
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1601348
Commit-Queue: Nick Burris <nburris@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662839}
6 files changed
tree: 18a88a495f88659867f79b90630f1cdfc823aa14
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. jingle/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. .clang-format
  52. .eslintrc.js
  53. .git-blame-ignore-revs
  54. .gitattributes
  55. .gitignore
  56. .gn
  57. .vpython
  58. AUTHORS
  59. BUILD.gn
  60. CODE_OF_CONDUCT.md
  61. codereview.settings
  62. DEPS
  63. ENG_REVIEW_OWNERS
  64. LICENSE
  65. LICENSE.chromium_os
  66. OWNERS
  67. PRESUBMIT.py
  68. PRESUBMIT_test.py
  69. PRESUBMIT_test_mocks.py
  70. README.md
  71. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .