commit | 791e1d6c4f8d6c2ac4a6d098314297d1ce270fe0 | [log] [tgz] |
---|---|---|
author | Tarcisio Fischer <tarcisio.fischer@arm.com> | Thu Oct 03 09:43:00 2024 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Thu Oct 03 09:43:00 2024 |
tree | adb42dae072929977238c193a58cf14e5c01eab3 | |
parent | a30e50c8f65dbcd86559692cea455d76591af3ad [diff] |
Fix Allocation Trace Recorder browser test The main goal was to fix the test flakyness, but there were also some issues because the test became outdated wrt the current implementation, so the test was also updated to take in consideration implementation changes. There's no guarantee that the flakyness is fixed, but the hypothesis is that it was flaky due to the fact it was using the "system-wide" DIR_CRASH_DUMPS path. This CL changes the test to use a more controlled temporary directory instead. This CL may be reverted if flakyness persists. Bug: 40944196 Change-Id: I5102c123d2162df81774c8566657169af343b86e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5816873 Reviewed-by: Ted Choc <tedchoc@chromium.org> Reviewed-by: Joe Mason <joenotcharles@google.com> Reviewed-by: Richard Townsend <richard.townsend@arm.com> Commit-Queue: Richard Townsend <richard.townsend@arm.com> Cr-Commit-Position: refs/heads/main@{#1363539}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.