Google Git
Sign in
chromium / chromium / src / 794c5dd1a2bde6254a3efc6e170167d5534bcb93
commit794c5dd1a2bde6254a3efc6e170167d5534bcb93[log] [tgz]
authorPeter McNeeley <petermcneeley@chromium.org>Wed Jul 05 20:59:41 2023
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Wed Jul 05 20:59:41 2023
treec0b98f5c1b9a5330c77d4d92d2666231b44e9195
parent82d1f87c036aed2c9962eaca2859b30980423d89 [diff]
Partial damage for primary plane overlay (non-delgating)


Partial damage for Lacros non-delegated has not been working properly
likely since a buffer queue refactor. The issue here is that normally
partial damage applies to |frame->sub_buffer_rect| on 'SwapBuffers'[0]
and then into |output_surface_plane_->damage_rect| on the gpu-main [1]
thread. However with buffer queue the primary plane overlay is
directly assigned in 'FinishDrawingFrame' which runs before the
previous two calls.

[0]
https://source.chromium.org/chromium/chromium/src/+/refs/heads/main:components/viz/service/display/skia_renderer.cc;drc=ac872e771ce001fef191848bab4167d60dfda403;bpv=1;bpt=1;l=1001


[1]
https://source.chromium.org/chromium/chromium/src/+/refs/heads/main:components/viz/service/display_embedder/skia_output_surface_impl_on_gpu.cc;drc=e510fa298843c8ff43b538742e4fa16306da265f;bpv=1;bpt=1;l=2261


Bug: 1459870
Change-Id: I1bdeae12fa097e030701b9e1683d3759bd1654db
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4665812
Reviewed-by: Kevin Haslett <khaslett@chromium.org>
Commit-Queue: Peter McNeeley <petermcneeley@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1166137}
1 file changed
tree: c0b98f5c1b9a5330c77d4d92d2666231b44e9195
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. weblayer/
  51. .clang-format
  52. .clang-tidy
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .mailmap
  59. .rustfmt.toml
  60. .vpython3
  61. .yapfignore
  62. ATL_OWNERS
  63. AUTHORS
  64. BUILD.gn
  65. CODE_OF_CONDUCT.md
  66. codereview.settings
  67. DEPS
  68. DIR_METADATA
  69. LICENSE
  70. LICENSE.chromium_os
  71. OWNERS
  72. PRESUBMIT.py
  73. PRESUBMIT_test.py
  74. PRESUBMIT_test_mocks.py
  75. README.md
  76. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.