commit 7990333d78f27decdfe9e1c6e44f35ac7db13e19
author Colin Blundell <blundell@chromium.org> Fri Jul 05 07:44:11 2024
committer Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> Fri Jul 05 07:44:11 2024
tree deb94a452659781a1b4bac2b1a7503bd3c662476
parent 4282bb1814ea0a5d8d297307739f9870e59aab8c

[Blink] Have CanvasResourceSwapChain get texture target from ClientSI

CanvasResourceSwapChain is only used on Windows. Its back buffer
SharedImage is guaranteed to be valid for its lifetime:
* It is CHECK()d in the constructor [1]
* It is cleared in TearDown [2], which is only called from the
  destructor

ClientSharedImage::GetTextureTarget() always returns GL_TEXTURE_2D on
Windows [3]. This CL changes CanvasResourceSwapChain::TextureTarget()
to call through to the back buffer CSI rather than hardcoding
GL_TEXTURE_2D as part of consolidating texture target logic within
ClientSharedImage across the codebase.

[1] https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/platform/graphics/canvas_resource.cc;l=1158-1160?q=canvas_resource.cc&ss=chromium
[2] https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/platform/graphics/canvas_resource.cc;l=1048-1049?q=canvas_resource.cc&ss=chromium
[3] https://source.chromium.org/chromium/chromium/src/+/main:gpu/command_buffer/client/client_shared_image.cc;l=47-66?q=ClientSharedImage::GetTe&ss=chromium

Bug: 41494843
Change-Id: I9cf384676a24828cc61c27d6cc20bddcf715560e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5678969
Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org>
Commit-Queue: Colin Blundell <blundell@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1323576}