Convert HttpTransaction to ByteSize

Throughout the network stack many layers pass byte counts around as
signed ints. It's often unclear which of those ints can hold negative
values in practice (such as -1 to indicate errors).

This makes it hard to deprecate ByteCount (signed) because the
replacement, ByteSize, is unsigned, and high-level ByteCount fields are
populated with values that come from deep in the network stack (eg. at
https://crsrc.org/c/third_party/blink/renderer/platform/exported/resource_load_info_notifier_wrapper.cc;l=201;drc=64820206068b8feaf4b9d4de22362cfcf047b8b6).

This replaces HttpTransaction methods returning int64_t, and all
implementations, with ByteSize. Followups can bubble up the ByteSize
type through the rest of the stack, checking whether negatives need to
be handled at each layer.

ByteSize holds values in the range [0,
std::numeric_limits<int64_t>::max()], so the call sites that convert
back to int64_t are guaranteed not to overflow.

All implementations already use unsigned data sources except
HttpNetworkTransaction which reads an int, but already checks for
positive values.

Internally, ByteSize CHECK's on overflow, so the only semantic change in
this patch is a safety improvement: previously out-of-range values could
overflow int64_t, now they will CHECK if that happens.

Bug: 448661443
Change-Id: Ic3d2df42dffdeddf5ff69e17fd3149fbbcafed62
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7726691
Auto-Submit: Joe Mason <joenotcharles@google.com>
Reviewed-by: Adam Rice <ricea@chromium.org>
Commit-Queue: Joe Mason <joenotcharles@google.com>
Cr-Commit-Position: refs/heads/main@{#1610804}
15 files changed
tree: 501477680bf1a5bb15fdd0f5dd11f04cf6ebfe1c
  1. .agents/
  2. .claude/
  3. .gemini/
  4. .github/
  5. agents/
  6. android_webview/
  7. apps/
  8. ash/
  9. base/
  10. build/
  11. build_overrides/
  12. buildtools/
  13. cc/
  14. chrome/
  15. chromecast/
  16. chromeos/
  17. codelabs/
  18. components/
  19. content/
  20. crypto/
  21. dbus/
  22. device/
  23. docs/
  24. extensions/
  25. fuchsia_web/
  26. gin/
  27. google_apis/
  28. gpu/
  29. headless/
  30. infra/
  31. ios/
  32. ipc/
  33. media/
  34. mojo/
  35. net/
  36. pdf/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. webkit/
  52. .clang-format
  53. .clang-tidy
  54. .clangd
  55. .cursorignore
  56. .geminiignore
  57. .git-blame-ignore-revs
  58. .gitallowed
  59. .gitattributes
  60. .gitignore
  61. .gitmodules
  62. .gn
  63. .mailmap
  64. .rustfmt.toml
  65. .vpython3
  66. .yapfignore
  67. ATL_OWNERS
  68. AUTHORS
  69. BUILD.gn
  70. CODE_OF_CONDUCT.md
  71. codereview.settings
  72. CPPLINT.cfg
  73. CRYPTO_OWNERS
  74. DEPS
  75. DIR_METADATA
  76. LICENSE
  77. LICENSE.chromium_os
  78. OWNERS
  79. package.json
  80. PRESUBMIT.py
  81. PRESUBMIT_test.py
  82. PRESUBMIT_test_mocks.py
  83. README.md
  84. SECURITY_OWNERS
  85. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.