commit 79f21bb11738b32941e14c2e38e414464c470349
author Sam Zackrisson <saza@chromium.org> Mon Jun 13 16:56:47 2022
committer Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> Mon Jun 13 16:56:47 2022
tree 176818cab40ca2ea7dd2047721fb1d8ae60f3d1f
parent 83e8ede33e86109c2762fd87db5444550d2e6fe0

media::AudioProcessor: Allow sample rates not divisible by 100 in render process

Support for these sample rates was removed in https://crrev.com/c/3551611

The WebRTC audio processing code is not consistently designed with non-divisible sample rates in mind, but there are input sources out there that rely on this behavior, mainly 22050 Hz. This CL also adds a warning log and updates the media::AudioProcessor API to clarify the support level (shaky) for non-divisible rates.

This CL does not add support for it in the audio process: That requires more work, covered in https://crbug.com/1332484. This will impact getUserMedia calls that explicitly request any audio processing effect for a device using a non-divisible sample rate like 22050 Hz when the Chrome-wide echo cancellation feature is enabled. This can be mitigated on a per-user basis by disabling the feature using this flag: chrome://flags/#chrome-wide-echo-cancellation.

(cherry picked from commit 83606679aeb21fd8d462f057b6e81f1a5fb00002)

Tested: New unit tests, and tested manually on Linux with/without Chrome-wide echo cancellation and instrumented 22050 Hz usage, verified logs.
Bug: chromium:1332528, chromium:1329493, chromium:1332484
Change-Id: I5d676cd550ad075a8cc7aa3231a6e5368cb1b83c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3672905
Reviewed-by: Olga Sharonova <olka@chromium.org>
Commit-Queue: Sam Zackrisson <saza@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1011371}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3702434
Cr-Commit-Position: refs/branch-heads/5060@{#787}
Cr-Branched-From: b83393d0f4038aeaf67f970a024d8101df7348d1-refs/heads/main@{#1002911}