Google Git
Sign in
chromium / chromium / src / 79f65ecfb9551e029e84389feb785edb939b7080
commit79f65ecfb9551e029e84389feb785edb939b7080[log] [tgz]
authorArthur Milchior <arthurmilchior@google.com>Wed May 14 12:21:43 2025
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Wed May 14 12:21:43 2025
treee4b24ee3c30b848fbab7837eb4076d509eb2229f
parent8daca42b261f0cce396e1e15af58b9037b71c13f [diff]
[iOS][Mim2]Replace requestHelper by delegate

Also, it ensures that the AuthenticationFlow is interrupted in the scene
controller’s tearDownUI is called.

The AuthenticationFlow should only outlive its owner in case of a change
of profile. And once the profile switch occur, the delegate is not used
anymore. So there is no issue with the fact that the delegate is weak.

If the scene is being tear down, the flow is getting interrupted, in
which case it should only use its delegate synchronously, while the
delegate still exists.

Change-Id: I1ce7d20a6fbd87bf2c47b7ace90939037659c718
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6459107
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Auto-Submit: Arthur Milchior <arthurmilchior@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1460001}
17 files changed
tree: e4b24ee3c30b848fbab7837eb4076d509eb2229f
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. crypto/
  16. dbus/
  17. device/
  18. docs/
  19. extensions/
  20. fuchsia_web/
  21. gin/
  22. google_apis/
  23. gpu/
  24. headless/
  25. infra/
  26. ios/
  27. ipc/
  28. media/
  29. mojo/
  30. native_client_sdk/
  31. net/
  32. pdf/
  33. ppapi/
  34. printing/
  35. remoting/
  36. rlz/
  37. sandbox/
  38. services/
  39. skia/
  40. sql/
  41. storage/
  42. styleguide/
  43. testing/
  44. third_party/
  45. tools/
  46. ui/
  47. url/
  48. webkit/
  49. clank
  50. internal
  51. ios_internal
  52. native_client
  53. signing_keys
  54. v8
  55. .clang-format
  56. .clang-tidy
  57. .clangd
  58. .git-blame-ignore-revs
  59. .gitallowed
  60. .gitattributes
  61. .gitignore
  62. .gitmodules
  63. .gn
  64. .mailmap
  65. .rustfmt.toml
  66. .vpython3
  67. .yapfignore
  68. ATL_OWNERS
  69. AUTHORS
  70. BUILD.gn
  71. CODE_OF_CONDUCT.md
  72. codereview.settings
  73. CPPLINT.cfg
  74. CRYPTO_OWNERS
  75. DEPS
  76. DIR_METADATA
  77. LICENSE
  78. LICENSE.chromium_os
  79. OWNERS
  80. PRESUBMIT.py
  81. PRESUBMIT_test.py
  82. PRESUBMIT_test_mocks.py
  83. README.md
  84. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.