Google Git
Sign in
chromium / chromium / src / 7a88158823ee9ad33684213801ba45965eb29eb3
commit7a88158823ee9ad33684213801ba45965eb29eb3[log] [tgz]
authorJoe Downing <joedow@google.com>Tue Jun 10 20:11:00 2025
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Tue Jun 10 20:11:00 2025
treeb36da6090baa594cbf5ee5c1c23672af81ee96ba
parent235ad0ff5ef443f818c6eae442f78a3e9d32a32d [diff]
Allow GCE metadata server override via environment variable

Compute Engine instances have a default metadata server but it is a
common practice for folks to create a custom metadata server. In
those cases, the admin may set an alternate host:port via an
environment variable named GCE_METADATA_HOST. This CL updates the
ComputeEngineServiceClient class to look for an override in the env
vars, otherwise it will use the default value.

An interesting twist is that this environment variable is set on the
try-bots so I need to modify our tests so it doesn't interfere with
them. I ended up splitting InstanceIdentityTokenGetter into an impl
and an interface so tests can create fake versions of it and adding
some tests for the InstanceIdentityTokenGetterImpl for the new
functionality.

Tested: Manually
Bug: NO_BUG
Change-Id: I9db2853896209321d24c8b82d2bbc947435e1caa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6631238
Reviewed-by: Yuwei Huang <yuweih@chromium.org>
Commit-Queue: Joe Downing <joedow@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1472031}
10 files changed
tree: b36da6090baa594cbf5ee5c1c23672af81ee96ba
  1. .github/
  2. android_webview/
  3. apps/
  4. ash/
  5. base/
  6. build/
  7. build_overrides/
  8. buildtools/
  9. cc/
  10. chrome/
  11. chromecast/
  12. chromeos/
  13. codelabs/
  14. components/
  15. content/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. gpu/
  25. headless/
  26. infra/
  27. ios/
  28. ipc/
  29. media/
  30. mojo/
  31. native_client_sdk/
  32. net/
  33. pdf/
  34. ppapi/
  35. printing/
  36. remoting/
  37. rlz/
  38. sandbox/
  39. services/
  40. skia/
  41. sql/
  42. storage/
  43. styleguide/
  44. testing/
  45. third_party/
  46. tools/
  47. ui/
  48. url/
  49. webkit/
  50. clank
  51. internal
  52. ios_internal
  53. native_client
  54. signing_keys
  55. v8
  56. .clang-format
  57. .clang-tidy
  58. .clangd
  59. .git-blame-ignore-revs
  60. .gitallowed
  61. .gitattributes
  62. .gitignore
  63. .gitmodules
  64. .gn
  65. .mailmap
  66. .rustfmt.toml
  67. .vpython3
  68. .yapfignore
  69. ATL_OWNERS
  70. AUTHORS
  71. BUILD.gn
  72. CODE_OF_CONDUCT.md
  73. codereview.settings
  74. CPPLINT.cfg
  75. CRYPTO_OWNERS
  76. DEPS
  77. DIR_METADATA
  78. LICENSE
  79. LICENSE.chromium_os
  80. OWNERS
  81. PRESUBMIT.py
  82. PRESUBMIT_test.py
  83. PRESUBMIT_test_mocks.py
  84. README.md
  85. SECURITY_OWNERS
  86. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.