Reland "Add basic logic for positioning the Picker widget near the caret."

This is a reland of commit 1a754aaf4bbf5bc9352e55a32f537cce0e43dcba

The original CL kept a const reference to the screen work area while
computing Picker bounds. This failed sanitizer tests since we don't
know the lifetime of the screen- it could be a temporary fake screen.

To fix this, copy the screen work area instead: see diff between
Patchset 1 and Patchset 3.

(Also make some other changes so that we're not overriding Layout()
to set the Picker widget bounds. See Patchset 4 and onwards.)

Original change's description:
> Add basic logic for positioning the Picker widget near the caret.
>
> - If there is space to the right of the caret, place the Picker widget
>   to the right of the caret and try to vertically align the Picker
>   search field with the caret.
> - Otherwise, place the Picker widget above or below the caret.
>
> Since we want to align the Picker search field with the caret, we only
> position the Picker widget after PickerView layout has happened.
>
> Note that various cases still need to be dealt with (e.g. when there is
> a selection instead of a caret). We'll handle these cases in followups.
>
> Bug: b:320787410, b:322281223
> Change-Id: I7cf427f3c8aa1e229c7a1cdcae1e3939457905aa
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5233749
> Commit-Queue: Michelle Chen <michellegc@google.com>
> Reviewed-by: Darren Shen <shend@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1251950}

Bug: b:320787410, b:322281223
Change-Id: Ia58e0e58d59eb753532cdb6ad85684cd2f7dcbc4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5247605
Reviewed-by: Darren Shen <shend@chromium.org>
Commit-Queue: Michelle Chen <michellegc@google.com>
Cr-Commit-Position: refs/heads/main@{#1253730}
4 files changed
tree: 1223bd9c6466b56a7b3888ff42558361103dc2f8
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. webkit/
  51. .clang-format
  52. .clang-tidy
  53. .clangd
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitallowed
  57. .gitattributes
  58. .gitignore
  59. .gitmodules
  60. .gn
  61. .mailmap
  62. .rustfmt.toml
  63. .vpython3
  64. .yapfignore
  65. ATL_OWNERS
  66. AUTHORS
  67. BUILD.gn
  68. CODE_OF_CONDUCT.md
  69. codereview.settings
  70. DEPS
  71. DIR_METADATA
  72. LICENSE
  73. LICENSE.chromium_os
  74. OWNERS
  75. PRESUBMIT.py
  76. PRESUBMIT_test.py
  77. PRESUBMIT_test_mocks.py
  78. README.md
  79. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.