Google Git
Sign in
chromium / chromium / src / 7af55352402d2f63fbdb121a4aca98b399ece780
commit7af55352402d2f63fbdb121a4aca98b399ece780[log] [tgz]
authorTheodor-Stefan Cristea <theocristea@google.com>Mon Sep 12 15:57:04 2022
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Mon Sep 12 15:57:04 2022
treea3fc3bc76777477af19719776e90a6fb6cbaa990
parent4faf8a8e182c5521187bcd5d9601644f229fe3d1 [diff]
Cleaned up redundant isMainFrame parameter of certain methods.

The methods receive the frame pointer as a parameter or already have mechanism in place for retrieving the current frame. Thus, we can find information about main frame by calling web::WebFrame::IsMainFrame() .

Bug: 1344776,881811
Change-Id: I43a924c96313ac69dbab5feff808df0b14129b8c

LOW_COVERAGE_REASON=Added a safety check in form_activity_tab_helper.mm

Change-Id: I43a924c96313ac69dbab5feff808df0b14129b8c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3880073
Reviewed-by: Mike Dougherty <michaeldo@chromium.org>
Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Reviewed-by: Viktor Semeniuk <vsemeniuk@google.com>
Commit-Queue: Theodor-Stefan Cristea <theocristea@google.com>
Reviewed-by: Maria Kazinova <kazinova@google.com>
Cr-Commit-Position: refs/heads/main@{#1045849}
26 files changed
tree: a3fc3bc76777477af19719776e90a6fb6cbaa990
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. weblayer/
  51. .clang-format
  52. .clang-tidy
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .mailmap
  59. .rustfmt.toml
  60. .vpython
  61. .vpython3
  62. .yapfignore
  63. AUTHORS
  64. BUILD.gn
  65. CODE_OF_CONDUCT.md
  66. codereview.settings
  67. DEPS
  68. DIR_METADATA
  69. ENG_REVIEW_OWNERS
  70. LICENSE
  71. LICENSE.chromium_os
  72. OWNERS
  73. PRESUBMIT.py
  74. PRESUBMIT_test.py
  75. PRESUBMIT_test_mocks.py
  76. README.md
  77. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.