Google Git
Sign in
chromium / chromium / src / 7b695f627704520be4fa2015946b1b7e84a61739
commit7b695f627704520be4fa2015946b1b7e84a61739[log] [tgz]
authorIvan Murashov <ivan.murashov@lge.com>Wed Jun 23 13:50:15 2021
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Wed Jun 23 13:50:15 2021
tree51769171c83bbfa790d383a65e6a87bc4b871b34
parentabe494bc52e8166b8813f2eb4758f9ba26c42ece [diff]
[Passwords] Avoid ambiguous reference to the LoginsReply

LoginsReply declared twice in the header files which causes an issues
with ambiguous usage.
Clang doesn't claims about it, but GCC does.
The errors example for GCC 9.3.0:
/components/password_manager/core/browser/password_store_impl.h:110:7:
error: reference to 'LoginsReply' is ambiguous
/components/password_manager/core/browser/password_store_backend.h:27:9:
note: candidates are: 'using LoginsReply = class
/components/password_manager/core/browser/password_store.h:321:9:
note: candidates are: 'using LoginsReply = class

Bug: 1217071, 1217070, 819294
Change-Id: I5ed4127d35c7d36f24dfa35e84310ba5128c4013
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2980536
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Commit-Queue: Ivan Murashov <ivan.murashov@lge.com>
Cr-Commit-Position: refs/heads/master@{#895117}
2 files changed
tree: 51769171c83bbfa790d383a65e6a87bc4b871b34
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. codelabs/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. jingle/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. weblayer/
  53. .clang-format
  54. .clang-tidy
  55. .eslintrc.js
  56. .git-blame-ignore-revs
  57. .gitattributes
  58. .gitignore
  59. .gn
  60. .mailmap
  61. .vpython
  62. .vpython3
  63. .yapfignore
  64. AUTHORS
  65. BUILD.gn
  66. CODE_OF_CONDUCT.md
  67. codereview.settings
  68. DEPS
  69. DIR_METADATA
  70. ENG_REVIEW_OWNERS
  71. LICENSE
  72. LICENSE.chromium_os
  73. OWNERS
  74. PRESUBMIT.py
  75. PRESUBMIT_test.py
  76. PRESUBMIT_test_mocks.py
  77. README.md
  78. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.