base/allocator: Don't zero already zeroed allocations in PartitionAlloc.

This was already attempted in the past, but had to be reverted due to
failures on macOS (see crbug.com/890752). This is because pages decommit
is not synchronous on macOS, but it is on other platorms.

The revert actually cost more performance than was necessary, as it
affected all platforms, and also newly allocated pages, which are
guaranteed to be zeroed on all operating systems. As a consequence,
allocating a large ArrayBuffer for instance can be pretty slow (and even
crash), since the memory is expliclty zeroed at the allocation site.

This CL adds the simplest fix:
- Newly allocated pages are never needlessly zeroed
- Recommitted ones are only zeroed on macOS

The expected impact is:
- Faster large allocations (and perhaps less crashy, at least on systems
  such as Linux/Android with overcommit), including ArrayBuffers.
- Faster allocations of zeroed memory on !macOS systems.

Bug: 864462, 890752, 998048
Change-Id: I4e3d7d8d63ecea41923db3b9ae8613719df7c712
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308419
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Benoit L <lizeb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#790417}
3 files changed
tree: c60d2ec6cf01a89125a7c1855caab8bd15621ac1
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. jingle/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. weblayer/
  52. .clang-format
  53. .clang-tidy
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitattributes
  57. .gitignore
  58. .gn
  59. .vpython
  60. .vpython3
  61. .yapfignore
  62. AUTHORS
  63. BUILD.gn
  64. CODE_OF_CONDUCT.md
  65. codereview.settings
  66. DEPS
  67. ENG_REVIEW_OWNERS
  68. LICENSE
  69. LICENSE.chromium_os
  70. OWNERS
  71. PRESUBMIT.py
  72. PRESUBMIT_test.py
  73. PRESUBMIT_test_mocks.py
  74. README.md
  75. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.