Revert "Use Font::BidiWidth in DrawTextInternal" This reverts commit f2b1ca3a5b343a31e1e2888a85d884f9f1d9d918. Reason for revert: This CL caused some performance regressions. We are still deciding if the cases fixed by using the Bidi algorithm when calculating width are worth the overhead it requires. Original change's description: > Use Font::BidiWidth in DrawTextInternal > > Before this change, when drawing text in BaseRenderingContext2D, > `font.Width()` was called directly to get the width and actual bounds of > the text to render. This is an issue when the input has certain > ligatures that are not calculated correctly this way, resulting in a > wrong positioning of the text if the text align is center or right, > given that the width is used to calculate the actual drawing position > required. > > This change uses `Font::BidiWidth()` instead, which works in the same > way, but first splits the original run in logical runs, and then > calculates the width and bounds of each of these runs with the > appropriate direction. > > Bug: 40858267 > Change-Id: I564d3219f4b3007d0218ce3829104f4392a6c92f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5479227 > Reviewed-by: Jean-Philippe Gravel <jpgravel@chromium.org> > Reviewed-by: Fernando Serboncini <fserb@chromium.org> > Commit-Queue: Andres Ricardo Perez <andresrperez@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1292625} Bug: 40858267, 337069173 Change-Id: I168bc924264632b11f17038b01a4b737cb0ee402 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5631929 Commit-Queue: Andres Ricardo Perez <andresrperez@chromium.org> Reviewed-by: Jean-Philippe Gravel <jpgravel@chromium.org> Cr-Commit-Position: refs/heads/main@{#1315802}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.