commit | 7b8a8ae663f23e0ae93437c5501bc3112e17ecaf | [log] [tgz] |
---|---|---|
author | manukh <manukh@chromium.org> | Wed May 05 23:38:34 2021 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Wed May 05 23:38:34 2021 |
tree | bade9314b438c24dfbcc2bb2e2bc4299f9a7a3ab | |
parent | 1e744db5d06944a40e201bfc5d028550e75dad0a [diff] |
[memories] Replace `cluster_visits` with `context_annotations` table. - This is CL 1 of 5 merging `ClusterVisitDatabase` with `VisitAnnotationsDatabase`. - This naming is consistent with the `content_annotations` table. - Also drops the `cluster_visit_id` column & field; we'll instead use `visit_id`s as the primary key as `context_annotations` have a 1-or-0 : 1 relationship with `visits`. This too is consistent with `content_annotations`. - Likewise, drops the `url_id` column & field; it's redundant since `context_annotations` are join with `visits` which already have `url_id`. - Renames the `cluster_visit_context_signal_bitmask` column to `context_annotation_flags` to be consistent with `content_annotations`'s `annotation_flags` column. Associated variables and methods will be renamed in a followup CL, but the column rename is done here to avoid an additional migration. - Removes `NOT NULL` requirement on some columns. - Follow up CLs will rename `ClusterVisit`, related structs, method names, and file names with `VisitContextAnnotations`. This is consistent with `VisitContentAnnotations`. Bug: 1179068, 1184879, 1184875, 1171352 Change-Id: I8ae50c70908c955a3547ab6da342c064a45e743f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2869588 Commit-Queue: manuk hovanesian <manukh@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Reviewed-by: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#879611}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.