commit | 7ba87bfa4cd10e38366d08f1282ff397c60e0370 | [log] [tgz] |
---|---|---|
author | Dominic Farolino <dom@chromium.org> | Wed Dec 14 15:59:01 2022 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Wed Dec 14 15:59:01 2022 |
tree | 44a335bdd3b544b1153365dfbbdd2c68c29a7f74 | |
parent | f5c74fadb9de0610bfd743fa3d34d23377c0d061 [diff] |
Fenced Frames: [4/N] Fledge `runAdAuction()` yields a FencedFrameConfig This CL doesn't fully implement the change advertised in the headline (resolving a web-exposed FencedFrameConfig object in the Promise returned from `runAdAuction()`); it is a refactoring in preparation for that change. This CL makes the RunAdAuction() IPC callback exclusively return an optional `blink::FencedFrame::RedactedFencedFrameConfig` to the renderer, where the `NavigationAuction` object is responsible for pulling the internal URN off of this object and returning it to script. This URN is identical to the URN that was previously returned to the renderer via the same callback, hence the "refactoring" nature of this CL. To do this, we add a non-nullable URL member to the blink.mojom.FencedFrameConfig struct, with appropriate validation and unit testing. A subsequent CL will modify the input dictionary to `runAdAuction()` to give web developers the ability to express that they want a full-blown config object returned to them in the `Promise` that `runAdAuction()` resolves to, not just a URN. That CL will be easy to write since the backing config will already be in place in the renderer. Bug: 1347953 Change-Id: I88a7ca0f8b59c7f31f9df406a8ef382c04d6c67d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4098955 Reviewed-by: Matt Menke <mmenke@chromium.org> Commit-Queue: Dominic Farolino <dom@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Garrett Tanzer <gtanzer@chromium.org> Cr-Commit-Position: refs/heads/main@{#1083114}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.