commit 7be01b9b4fc8b356f8f9050c29430c8d01a7414d
author Xiaodan Zhu <zxdan@chromium.org> Fri Mar 17 00:55:52 2023
committer Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> Fri Mar 17 00:55:52 2023
tree 5b871f42460fa17617fa7ab4cfbcc67f3359a98e
parent de4e3a6f6c680fc1f6041ba2850e92b3ec99679c

cros_next: make switch inherit from ToggleButton

Previously, we built the KnobSwitch class from scratch. However
the existing ToggleButton has similar functionalities and also
implements the animation, hover layer, ink drop layer and
animation. To avoid re-invent the wheel, we decide to make
KnobSwitch inherit from ToggleButton. This cl makes following
changes:

The changes in ui/views/controls/button/toggle_button.*:
- Change the type of thumb on/off colors and track on/off
colors from absl::optional to
absl::variant<ui::ColorId, SkColor> such that they can hold
both color ID and color value.
- Update the enabled/disabled colors when the enabled state
of ToggleButton is changed.
- Add a new has_thumb_shadow_ attribute in ToggleButton such
that the sub classes can specify if they want a thumb shadow.
- Add a new has_shadow_ attribute in ThumbView to receive the
value of has_thumb_shadow_ from ToggleButton.
- Make GetFocusRingPath, GetTrackBounds and GetThumbBounds as
virtual protected methods such the the sub classes can override
them.
- Add a protected method GetAnimationProgress for sub classes
to get the value from slide animation.

The changes in ash/style/ash_color_mixer
- Change the toggle button related colors with dynamic color Id
in ash color mixers.

The changes in ash/style/knob_switch.*
- Change the name from KnobSwitch to Switch because many people
feel the name knob switch is confusing.
- Inherit the Switch from ToggleButton and override the
GetFocusRingPath, GetTrackBounds, and GetThumbBounds.

The final effects will be shown in bug comment.

Bug: b:271330235
Change-Id: I7051484ea80656ce97cc837fef79641a4b1708ca
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4338876
Reviewed-by: Sean Kau <skau@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Xiaodan Zhu <zxdan@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1118466}