| commit | 7be97a4288d06d3d49a11a3785f9ed67bb7874f9 | [log] [tgz] |
|---|---|---|
| author | Sunggook Chue <sunggch@microsoft.com> | Fri Jan 07 21:11:58 2022 |
| committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Fri Jan 07 21:11:58 2022 |
| tree | 3ad1a5a1ac884a1ecd2813d996781fee81583ab2 | |
| parent | 7a836e02f9aaef5c6217b81b17de8899c6ffa2ea [diff] |
[dPWA] Correctly quit chrome on OsSettings uninstall, and cleanup. This change fixes the case where OsSettings uninstall, when triggered while no chrome browsers were open, causes chrome to never terminate. It does this by now holding a ScopedKeepAlive during the uninstall operation. It also cleans up OsSettings if this uninstallation was triggered when it should not be possible. Bug: 1278159 Change-Id: I02ef4dd85ad6ae8972d7e467f513b69c536dabb3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3326061 Reviewed-by: Daniel Murphy <dmurph@chromium.org> Reviewed-by: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Commit-Queue: Sunggook Chue <sunggch@microsoft.com> Cr-Commit-Position: refs/heads/main@{#956658}
ChromiumChromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.