[ozone] Fixed the logic that forces using the custom frame.

This CL fixes the linked crbug by improving the condition checked in
DesktopBrowserFrameAuraLinux::UseCustomFrame() when Ozone is enabled.

The method returns whether the window frame should use client-side
decorations, and it returned true by mistake.  The wrong condition
assumed that if the platform suggests using the custom frame (that is,
OzonePlatform::ShouldUseCustomFrame() returns true), that means that the
platform lacks support for server-side decorations.  In fact, that is
not correct; the right thing to check is the runtime platform property
named supports_server_side_window_decorations [1] that is not a
suggestion but indicates clearly whether the feature is supported.

[1] https://source.chromium.org/chromium/chromium/src/+/master:ui/ozone/public/ozone_platform.h;l=162;bpv=1;bpt=0;drc=66b50ba4201acf8356be5419eee5404d03d52d7a

Bug: 1243937
Change-Id: Iaf69f6e6ef2f178dc568f5c30847dcce42f3d896
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3133066
Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Commit-Queue: Alexander Dunaev <adunaev@igalia.com>
Cr-Commit-Position: refs/heads/main@{#918438}
7 files changed
tree: a3d3600e981c40f9380e16628fa7751054bb4ed8
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. codelabs/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. jingle/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. weblayer/
  53. .clang-format
  54. .clang-tidy
  55. .eslintrc.js
  56. .git-blame-ignore-revs
  57. .gitattributes
  58. .gitignore
  59. .gn
  60. .mailmap
  61. .vpython
  62. .vpython3
  63. .yapfignore
  64. AUTHORS
  65. BUILD.gn
  66. CODE_OF_CONDUCT.md
  67. codereview.settings
  68. DEPS
  69. DIR_METADATA
  70. ENG_REVIEW_OWNERS
  71. LICENSE
  72. LICENSE.chromium_os
  73. OWNERS
  74. PRESUBMIT.py
  75. PRESUBMIT_test.py
  76. PRESUBMIT_test_mocks.py
  77. README.md
  78. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.