commit | 7c9ce947e5d9aabeaa6a517e8bb698b005cdc426 | [log] [tgz] |
---|---|---|
author | Andrew Paseltiner <apaseltiner@chromium.org> | Mon Jun 30 13:06:51 2025 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Mon Jun 30 13:06:51 2025 |
tree | 5f89c54a33d73f600567536c0487abd41ff9e4b2 | |
parent | c71f37b233c7cdc6792d9cdc16fc87609c608d94 [diff] |
[M139] Account for iterator invalidation during registration processing Original change's description: > Account for iterator invalidation during registration processing > > Prior to this change, it was possible for the set of registrations to be > modified while the ClearRegistrationsDeferUntilNavigation method was > iterating over it, leading to invalid accesses. In this change, we make > a copy of the registration IDs to be processed, and only process them if > they are still present in the set, effectively making this method not > only safe against the immediate iterator-invalidation problem, but also > reentrant. > > Bug: 427800555 > Change-Id: I9cb11adb69aef44a1766cca23b9b0ba4bf061027 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6682165 > Reviewed-by: Nan Lin <linnan@chromium.org> > Commit-Queue: Andrew Paseltiner <apaseltiner@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1479770} Bug: 428199449,427800555 Change-Id: I9cb11adb69aef44a1766cca23b9b0ba4bf061027 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6689866 Auto-Submit: Chrome Cherry Picker <chrome-cherry-picker@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/7258@{#385} Cr-Branched-From: f600d0656fd5b5fe4a82981f533d31ed6939e2e4-refs/heads/main@{#1477651}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.