Google Git
Sign in
chromium / chromium / src / 7cbe1bfdc9399ddb989227ca52b52837470b0bd4
commit7cbe1bfdc9399ddb989227ca52b52837470b0bd4[log] [tgz]
authorVeronique Nguyen <veronguyen@google.com>Tue Jun 27 15:34:19 2023
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Tue Jun 27 15:34:19 2023
tree8d17e2ac8596a592f09243c36b087ea0275339ee
parent05b2d867c0a09cfe2785b23bb51b41dc96cf1e65 [diff]
[Merge 116][NOTREACHED] Fix AccountSelectFillData::GetFillData crash

This happens because we call AccountSelectFillData::Reset() and it
sets last_requested_form_ = nullptr.

In our case, we just want to clear the credentials_ cache. I made a
separate method to clear that cache only.

(cherry picked from commit db0ba831f7e832446e8e5c546fc205daac7cfe9d)

Bug: 1457248
Change-Id: Ia5305015f520815bc367cc9fea80adcde6889a92
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4638202
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Commit-Queue: Veronique Nguyen <veronguyen@google.com>
Cr-Original-Commit-Position: refs/heads/main@{#1161726}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4651208
Cr-Commit-Position: refs/branch-heads/5845@{#138}
Cr-Branched-From: 5a5dff63a4a4c63b9b18589819bebb2566c85443-refs/heads/main@{#1160321}
3 files changed
tree: 8d17e2ac8596a592f09243c36b087ea0275339ee
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. weblayer/
  51. .clang-format
  52. .clang-tidy
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .mailmap
  59. .rustfmt.toml
  60. .vpython3
  61. .yapfignore
  62. ATL_OWNERS
  63. AUTHORS
  64. BUILD.gn
  65. CODE_OF_CONDUCT.md
  66. codereview.settings
  67. DEPS
  68. DIR_METADATA
  69. LICENSE
  70. LICENSE.chromium_os
  71. OWNERS
  72. PRESUBMIT.py
  73. PRESUBMIT_test.py
  74. PRESUBMIT_test_mocks.py
  75. README.md
  76. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.