commit | 7cc6f7a6139e4ac3ec1a0c59dda940f254b4890d | [log] [tgz] |
---|---|---|
author | Nigel Tao <nigeltao@chromium.org> | Thu Mar 14 09:13:38 2019 |
committer | Commit Bot <commit-bot@chromium.org> | Thu Mar 14 09:13:38 2019 |
tree | 97344ef1d4a42fe3e34204d9e068fe10f5ee1726 | |
parent | 6bc8beb80d8f0f668ce252d951aef1e2e6432237 [diff] |
Clarify that AppIconLoader::icon_size is in DIP As is, "icon_size" is an int, and it's not immediately obvious whether that's measured in DIPs (Density Indepent Pixels) or in physical pixels. Also change ChromeAppIconLoader's argument name from "etc_dips" to "etc_dip", consistent with the vast majority of Chromium code: https://cs.chromium.org/search/?q=in_dip&sq=package:chromium&type=cs https://cs.chromium.org/search/?q=in_dips&sq=package:chromium&type=cs Change-Id: I94495ca4f357c52106aab331581d90a0d7e82a6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1510695 Reviewed-by: Yury Khmel <khmel@chromium.org> Reviewed-by: Trent Apted <tapted@chromium.org> Reviewed-by: Ben Wells <benwells@chromium.org> Commit-Queue: Nigel Tao <nigeltao@chromium.org> Cr-Commit-Position: refs/heads/master@{#640627}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .