Google Git
Sign in
chromium / chromium / src / 7ccb06a0d539d2e647e0cb1590f417fbd62ee239
commit7ccb06a0d539d2e647e0cb1590f417fbd62ee239[log] [tgz]
authorBenjamin Williams <bwwilliams@google.com>Fri Sep 20 21:13:49 2024
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Fri Sep 20 21:13:49 2024
tree01a8d6e49d82811e67d2327fe963f8143ee9a1ca
parent0c503dbda099e21739a28b4e6d2bd536a8026410 [diff]
[iOS] Decouple push notification feature enabling from provisional auth

This CL introduces a new argument, featureEnabledForProvisional, to the
enrollUserToProvisionalNotificationsForClientIds: method. This argument
allows push notification clients to decouple the enabling of a feature
from the granting of provisional push notification authorization.

Previously, enabling provisional notifications for a feature also
implicitly enabled the feature itself. This change allows for more
granular control, enabling clients to request provisional authorization
without necessarily turning the feature on.

This is useful in cases where clients want to prompt the user for
provisional notifications before they explicitly enable the feature,
allowing for a smoother onboarding experience.

Change-Id: Ie56040f482834557db61209dbcfa1d8324fb4b8b
Fixed: 368639856
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5879016
Reviewed-by: Adam Arcaro <adamta@google.com>
Commit-Queue: Guillem Perez <guiperez@google.com>
Reviewed-by: Guillem Perez <guiperez@google.com>
Auto-Submit: Benjamin Williams <bwwilliams@google.com>
Cr-Commit-Position: refs/heads/main@{#1358377}
6 files changed
tree: 01a8d6e49d82811e67d2327fe963f8143ee9a1ca
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. crypto/
  16. dbus/
  17. device/
  18. docs/
  19. extensions/
  20. fuchsia_web/
  21. gin/
  22. google_apis/
  23. google_update/
  24. gpu/
  25. headless/
  26. infra/
  27. ios/
  28. ipc/
  29. media/
  30. mojo/
  31. native_client_sdk/
  32. net/
  33. pdf/
  34. ppapi/
  35. printing/
  36. remoting/
  37. rlz/
  38. sandbox/
  39. services/
  40. skia/
  41. sql/
  42. storage/
  43. styleguide/
  44. testing/
  45. third_party/
  46. tools/
  47. ui/
  48. url/
  49. webkit/
  50. clank
  51. internal
  52. ios_internal
  53. native_client
  54. signing_keys
  55. v8
  56. .clang-format
  57. .clang-tidy
  58. .clangd
  59. .eslintrc.js
  60. .git-blame-ignore-revs
  61. .gitallowed
  62. .gitattributes
  63. .gitignore
  64. .gitmodules
  65. .gn
  66. .mailmap
  67. .rustfmt.toml
  68. .vpython3
  69. .yapfignore
  70. ATL_OWNERS
  71. AUTHORS
  72. BUILD.gn
  73. CODE_OF_CONDUCT.md
  74. codereview.settings
  75. CPPLINT.cfg
  76. CRYPTO_OWNERS
  77. DEPS
  78. DIR_METADATA
  79. LICENSE
  80. LICENSE.chromium_os
  81. OWNERS
  82. PRESUBMIT.py
  83. PRESUBMIT_test.py
  84. PRESUBMIT_test_mocks.py
  85. README.md
  86. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.