commit 7cda3aef8c68583af34c3544051e02cbe581939a
author Andrew Xu <andrewxu@chromium.org> Wed Jul 27 19:23:55 2022
committer Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> Wed Jul 27 19:23:55 2022
tree 4a069b836eb0ab7ac43bf1d9c6dcc94d9d247d05
parent 2fa1f510f25d5899a5a9532c821b7049db390f7f

[Launcher] Reland: fix the issue that placeholder icons do not show

The previous CL (https://crrev.com/c/3781602) got reverted
because when calling `AppListModelUpdater::SetItemIconAndColor()`
from `ChromeAppListItem::SetIcon()`, the reference to the id is passed
to the function as the argument. Meanwhile, during setting the item
icon, the metadata that owns the id could be reset.

In the latest patch, a copy of the id is passed as the argument.

The patch set 1 is the original CL.

The previous CL description:

This CL fixes the regression issue introduced by this CL:
https://crrev.com/c/3499153

Currently, the app list item view's icon gets updated only when
the icon color changes. However, given that the icon color is sampled
from an icon, it is not guaranteed that two different icons must have
different extracted colors.

To fix this issue, always update the app list item view icon even
if the icon color does not change. Meanwhile, sync the icon color
only if the new icon color is different.

Add a browser test to check app list sort with placeholder icons.

TODO: add a pixel diff test for this scenario
Change-Id: Ie72bffe6b8868a8d7a2e20f3efcfce3c604d5a5d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3783936
Reviewed-by: Toni Barzic <tbarzic@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Andrew Xu <andrewxu@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1028854}