Improve third-party NTPs creation performance by using spare renderer

The current implementation of the third-party NTPs in the browser does
not make use of the spare renderer. As a result, third-party search
engine NTPs that depend on the current architecture experience delays
because they have to create a new process rather than reusing an
existing spare renderer.

This change primarily updates three parts. First, we have to late-bind
the instant process flag. Currently, the flag is passed as a
command-line switch when the process is created, which prevents spare
renderers from attaching the instant process flag as spare renderers
doesn't know if it's instant process at that moment. To address this
issue, we introduce a new method, SetConfigurationOnProcessLockUpdate(),
in the existing RendererConfiguration mojom interface. This method is
called in NotifyRendererOfLockedStateUpdate() to late bind the instant
process flag when process lock is updated. Additionally, we reuse
process_state.cc to store and expose the instant process setting.

The 2nd part of the change aims to enable the instant process to utilize
the spare renderer. We introduced a feature flag,
kInstantUsesSpareRenderer, to serve as the experimental control flag.
Additionally, we updated ChromeContentBrowserClient::IsSuitableHost() to
bypass the check if the spare renderer is taken by the instant process.
We made this change because InstantService::AddInstantProcess is called
after RenderProcessHostImpl::MayReuseAndIsSuitable() check in
RenderProcessHostImpl::GetProcessHostForSiteInstance(), which could hit
the "Unsuitable process reused for site" NOTREACHED.

The third part is to ensure that the renderer security settings are
passed to the process in time, before the renderer thread is created.
However, the order of mojo calls is not guaranteed on non-associated
interfaces in service worker cases. Therefore, we add
WaitForProcessReady() to make the service worker creation thread wait
until the renderer configuration (instant flag) and other
security-related settings are set before attempting to create the
worker.

Bug: 398159675
Change-Id: Ib7c3a7ca1bedae9174cd415e313ef43cfaf06b7a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6373046
Commit-Queue: Wangsong Jin <wangsongjin@microsoft.com>
Reviewed-by: Marc Treib <treib@chromium.org>
Reviewed-by: Shunya Shishido <sisidovski@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1501448}
31 files changed
tree: 29c9e2023ddc5c6de176cc4be3ea42414436ffe5
  1. .gemini/
  2. .github/
  3. agents/
  4. android_webview/
  5. apps/
  6. ash/
  7. base/
  8. build/
  9. build_overrides/
  10. buildtools/
  11. cc/
  12. chrome/
  13. chromecast/
  14. chromeos/
  15. codelabs/
  16. components/
  17. content/
  18. crypto/
  19. dbus/
  20. device/
  21. docs/
  22. extensions/
  23. fuchsia_web/
  24. gin/
  25. google_apis/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. media/
  32. mojo/
  33. net/
  34. pdf/
  35. printing/
  36. remoting/
  37. rlz/
  38. sandbox/
  39. services/
  40. skia/
  41. sql/
  42. storage/
  43. styleguide/
  44. testing/
  45. third_party/
  46. tools/
  47. ui/
  48. url/
  49. webkit/
  50. .clang-format
  51. .clang-tidy
  52. .clangd
  53. .cursorignore
  54. .geminiignore
  55. .git-blame-ignore-revs
  56. .gitallowed
  57. .gitattributes
  58. .gitignore
  59. .gitmodules
  60. .gn
  61. .mailmap
  62. .rustfmt.toml
  63. .vpython3
  64. .yapfignore
  65. ATL_OWNERS
  66. AUTHORS
  67. BUILD.gn
  68. CODE_OF_CONDUCT.md
  69. codereview.settings
  70. CPPLINT.cfg
  71. CRYPTO_OWNERS
  72. DEPS
  73. DIR_METADATA
  74. LICENSE
  75. LICENSE.chromium_os
  76. OWNERS
  77. PRESUBMIT.py
  78. PRESUBMIT_test.py
  79. PRESUBMIT_test_mocks.py
  80. README.md
  81. SECURITY_OWNERS
  82. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.