Google Git
Sign in
chromium / chromium / src / 7d1fee1458cdd1adc7785856c2e4b5a4d933d74c
commit7d1fee1458cdd1adc7785856c2e4b5a4d933d74c[log] [tgz]
authorDibyajyoti Pal <dibyapal@google.com>Fri Jul 12 02:24:42 2024
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Fri Jul 12 02:24:42 2024
treeba849e04b0453a6899288be15a03d8cbc3a0478c
parent461592150c4a155431a01da7182e10e4a9afbe44 [diff]
[PWA] Create base PiP window testing class for web applications

In c/b/ui/web_applications/, AppBrowserDocumentPictureInPictureBrowserTest
has enough logic to be resuable across the web_applications/ area in
various tests that verify workings of the web_applications/ system with
respect to PiP windows.

This CL moves that logic into a separate mixin class so that it can be
used across multiple test bases and reused anywhere for web applications/ code. This will make writing tests for
crrev.com/c/5689758 very easy.

To make this work, PostRunTestOnMainThread() had to be implemented inside MixinBasedInProcessBrowserTest, hence the changes in
chrome/test/base.

Bug: 350256139
Change-Id: Ib2cd14e8b7355ecf5847017232ed7bd6d0315d4b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5696468
Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Commit-Queue: Dibyajyoti Pal <dibyapal@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1326519}
6 files changed
tree: ba849e04b0453a6899288be15a03d8cbc3a0478c
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. webkit/
  51. clank
  52. internal
  53. ios_internal
  54. native_client
  55. signing_keys
  56. v8
  57. .clang-format
  58. .clang-tidy
  59. .clangd
  60. .eslintrc.js
  61. .git-blame-ignore-revs
  62. .gitallowed
  63. .gitattributes
  64. .gitignore
  65. .gitmodules
  66. .gn
  67. .mailmap
  68. .rustfmt.toml
  69. .vpython3
  70. .yapfignore
  71. ATL_OWNERS
  72. AUTHORS
  73. BUILD.gn
  74. CODE_OF_CONDUCT.md
  75. codereview.settings
  76. CPPLINT.cfg
  77. DEPS
  78. DIR_METADATA
  79. LICENSE
  80. LICENSE.chromium_os
  81. OWNERS
  82. PRESUBMIT.py
  83. PRESUBMIT_test.py
  84. PRESUBMIT_test_mocks.py
  85. README.md
  86. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.