commit 7d2463ba30888d299744d0f4143a75614cc8d717
author David Bertoni <dbertoni@chromium.org> Mon Aug 19 19:50:40 2024
committer Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> Mon Aug 19 19:50:40 2024
tree 62c4b2a048c9d8e166167b00719fa5a2ca5dfd4e
parent 8b8f1df188b49d9d2d4b5fc035a02bb690a13e3a

[Extensions] Clean up some dependencies in the bookmarks API.

This CL addresses the following issues:

1. ExtensionActivityMonitor needlessly references BookmarkFunction,
which breaks layering. This is fixed by changed interfaces to use
the ExtensionFunction base class. Since BookmarkFunction doesn't
add any new public member functions, this doesn't result in any loss
of information. Also, the observer API includes a parameter for the
calling extension, but that information is available from the
ExtensionFunction instance, so this parameter is unneeded.

2. Some general cleanup, including adding braces and using
base::MakeRefCounted.

This change allows for moving BookmarksApiWatcher into a separate
source set in a future CL and reduces coupling between the bookmarks
API and the sync subsystem. There is also a possibility to move
BookmarksApiWatcher into extensions/browser/api/bookmarks by
making BookmarksApiWatcherFactory a BrowserContextKeyedServiceFactory
instead of a ProfileKeyedServiceFactory.

It may be worth considering a more generic way to observe function
dispatch in extensions/browser, which would further reduce coupling.

Bug: 40593486
Change-Id: I8faeace4f55823270f53bf83844e8bc9caf43962
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5794220
Reviewed-by: Devlin Cronin <rdevlin.cronin@chromium.org>
Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com>
Reviewed-by: Jood Hajeer <jood@google.com>
Auto-Submit: David Bertoni <dbertoni@chromium.org>
Commit-Queue: David Bertoni <dbertoni@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1343686}