Revert "Fix a clickjacking out-of-screen Autofill popup issue" This reverts commit b4f503e5ac9434d71742855e548f243098d35071. Reason for revert: LUCI Bisection has identified this change as the cause of a test failure. See the analysis: https://ci.chromium.org/ui/p/chromium/bisection/test-analysis/b/5154229313339392 Sample build with failed test: https://ci.chromium.org/b/8704575934091332833 Affected test(s): [ninja://chrome/test:unit_tests/PopupViewViewsTest.PopupPositioning](https://ci.chromium.org/ui/test/chromium/ninja:%2F%2Fchrome%2Ftest:unit_tests%2FPopupViewViewsTest.PopupPositioning?q=VHash%3A799aae891109c818) If this is a false positive, please report it at http://b.corp.google.com/createIssue?component=1199205&description=Analysis%3A+https%3A%2F%2Fci.chromium.org%2Fui%2Fp%2Fchromium%2Fbisection%2Ftest-analysis%2Fb%2F5154229313339392&format=PLAIN&priority=P3&title=Wrongly+blamed+https%3A%2F%2Fchromium-review.googlesource.com%2Fc%2Fchromium%2Fsrc%2F%2B%2F6779373&type=BUG Original change's description: > Fix a clickjacking out-of-screen Autofill popup issue > > Autofill popups could appear on the page off-screen horizontally. > This CL restricts popup-generating elements to appear at least 100px > horizontally on-screen to generate the popup. > > Bug: 430555440 > Change-Id: Ic0d66a980d6bf80d033b0b7ea96ae2bb76067317 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6779373 > Auto-Submit: Mikita Kuchyn <kuchyn@chromium.org> > Reviewed-by: Jan Keitel <jkeitel@google.com> > Reviewed-by: Dominic Battré <battre@chromium.org> > Commit-Queue: Jan Keitel <jkeitel@google.com> > Cr-Commit-Position: refs/heads/main@{#1511370} > Bug: 430555440 No-Presubmit: true No-Tree-Checks: true No-Try: true Change-Id: I6eb01e9b6e339a5ade6cadee277249c2fb54a430 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6918682 Commit-Queue: Jan Keitel <jkeitel@google.com> Reviewed-by: Jan Keitel <jkeitel@google.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1511464}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.