terminal: Simplify LoadIconsFromResources code

Replace the callback-driven LoadIconsFromResources with FromVectorIcon.

Also, rebuild the vector_icon to use
ui/file_manager/file_manager/foreground/images/volumes/linux_files.svg
instead of chrome/app/theme/crostini/crostini_mascot_1x.svg (since
deleted).

This slightly changes the rendering of the new tab menu:

Before: https://bugs.chromium.org/p/chromium/issues/attachment?aid=538562&signed_aid=t-7gbXeondkvFNWl3WIUvw==&inline=1
After: https://bugs.chromium.org/p/chromium/issues/attachment?aid=539202&signed_aid=SdGKXBsBfmdJRra87vmUBA==&inline=1

The right-click menu doesn't change. Also, the shortcut icons are meant
to be larger than the rest of the icons in the right-click menu, so we
keep the same size as before: kAppShortcutIconSizeDip.

Bug: 1241262
Change-Id: I5f41fde3025d3275f4020b88bf2979a5c04f4f08
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3414175
Reviewed-by: Jason Lin <lxj@google.com>
Reviewed-by: Joel Hockey <joelhockey@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Commit-Queue: Emil Mikulic <easy@google.com>
Cr-Commit-Position: refs/heads/main@{#963848}
2 files changed
tree: 8fb016ccb639f2da752cf375d54b1d24d589e6d5
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. codelabs/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. weblayer/
  52. .clang-format
  53. .clang-tidy
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitattributes
  57. .gitignore
  58. .gn
  59. .mailmap
  60. .rustfmt.toml
  61. .vpython
  62. .vpython3
  63. .yapfignore
  64. AUTHORS
  65. BUILD.gn
  66. CODE_OF_CONDUCT.md
  67. codereview.settings
  68. DEPS
  69. DIR_METADATA
  70. ENG_REVIEW_OWNERS
  71. LICENSE
  72. LICENSE.chromium_os
  73. OWNERS
  74. PRESUBMIT.py
  75. PRESUBMIT_test.py
  76. PRESUBMIT_test_mocks.py
  77. README.md
  78. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.