Google Git
Sign in
chromium / chromium / src / 7dd79c1e4213698c5d4909d78007e9cc22ab720f
commit7dd79c1e4213698c5d4909d78007e9cc22ab720f[log] [tgz]
authorErin Stewart <erinstewart@google.com>Fri Jun 28 19:53:20 2024
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Fri Jun 28 19:53:20 2024
treefe3ed5215c1e772e040bd9384479435a33135d9f
parent005a3c5cb3e03e629021813aaa75ee49589f00e1 [diff]
Revert "Extract source_location.mojom to its own build target"

This reverts commit 25dbf0601e923498311875c35cfc3b05bda7be74.

Reason for revert: CaptureSourceLocation() is needed to get the source location so that it can be reported, but it reads the entire stack trace, which is very costly and was causing performance regressions

Bug: 346617710
Bug: 346617122
Bug: b/341594082

Original change's description:
> Extract source_location.mojom to its own build target
>
> Upcoming changes will make restricted_cookie_manager.mojom and cookie_access_observer.mojom dependent on it, so this is needed to prevent a circular dependency
>
> Bug: b/341594082
> Change-Id: Ib568b78a1adf6d1247e0eff0ea222b9ef864ab2a
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5581650
> Reviewed-by: Reilly Grant <reillyg@chromium.org>
> Reviewed-by: Ken Buchanan <kenrb@chromium.org>
> Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
> Commit-Queue: Reilly Grant <reillyg@chromium.org>
> Auto-Submit: Erin Stewart <erinstewart@google.com>
> Cr-Commit-Position: refs/heads/main@{#1308238}

Change-Id: I6475d2b25118a2adc1f4e9fcd4150a7c29f88b0d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5664054
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Commit-Queue: Erin Stewart <erinstewart@google.com>
Cr-Commit-Position: refs/heads/main@{#1321148}
4 files changed
tree: fe3ed5215c1e772e040bd9384479435a33135d9f
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. webkit/
  51. clank
  52. internal
  53. ios_internal
  54. native_client
  55. signing_keys
  56. v8
  57. .clang-format
  58. .clang-tidy
  59. .clangd
  60. .eslintrc.js
  61. .git-blame-ignore-revs
  62. .gitallowed
  63. .gitattributes
  64. .gitignore
  65. .gitmodules
  66. .gn
  67. .mailmap
  68. .rustfmt.toml
  69. .vpython3
  70. .yapfignore
  71. ATL_OWNERS
  72. AUTHORS
  73. BUILD.gn
  74. CODE_OF_CONDUCT.md
  75. codereview.settings
  76. CPPLINT.cfg
  77. DEPS
  78. DIR_METADATA
  79. LICENSE
  80. LICENSE.chromium_os
  81. OWNERS
  82. PRESUBMIT.py
  83. PRESUBMIT_test.py
  84. PRESUBMIT_test_mocks.py
  85. README.md
  86. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.