Google Git
Sign in
chromium / chromium / src / 56e969f5eb58b485ae95eeafbfffe60344d1fa5b
commit56e969f5eb58b485ae95eeafbfffe60344d1fa5b[log] [tgz]
authorBence Béky <bnc@chromium.org>Wed Aug 01 13:04:16 2018
committerCommit Bot <commit-bot@chromium.org>Wed Aug 01 13:04:16 2018
tree2bc42088d61a86508d50326cd21c7c7f4250a2ae
parenteea229f2451fbd8d3c8e4920116f6f591eaab49c [diff]
Relax favicon load related test expectations.

I introduced some test expectations in https://crrev.com/c/1145129 which
I believe might be unnecessarily strict.  In particular,
Net.ConnectionInfo.MainFrame and Net.ConnectionInfo.SubResource might be
recorded in OnReceivedResponse() for favicon but RecordLoadHistograms()
not called yet by the time test execution arrives to the expectations.
This CL relaxes some expectations to prevent these tests from becoming
flaky.

Bug: 859546
Change-Id: Idbacc7d024176406c5eb1a4be6d190e168a7d432
Reviewed-on: https://chromium-review.googlesource.com/1156848
Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Bence Béky <bnc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579784}
1 file changed
tree: 2bc42088d61a86508d50326cd21c7c7f4250a2ae
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. blink/
  6. build/
  7. build_overrides/
  8. cc/
  9. chrome/
  10. chrome_elf/
  11. chromecast/
  12. chromeos/
  13. cloud_print/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. jingle/
  31. mash/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. webrunner/
  53. .clang-format
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitattributes
  57. .gitignore
  58. .gn
  59. .vpython
  60. AUTHORS
  61. BUILD.gn
  62. CODE_OF_CONDUCT.md
  63. codereview.settings
  64. DEPS
  65. ENG_REVIEW_OWNERS
  66. LICENSE
  67. LICENSE.chromium_os
  68. OWNERS
  69. PRESUBMIT.py
  70. PRESUBMIT_test.py
  71. PRESUBMIT_test_mocks.py
  72. README.md
  73. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .