animation: fix infinitely growing models list

https://crrev.com/c/4605129 made it so that an updated animation in
Blink resulting in a cancel/re-create of a compositor animation would
reuse the compositor animation's id and group, causing it to push new
properties to the existing compositor-thread animation, rather than
creating a new animation. While this preserves the Animation and
KeyframeEffect, it pushes new KeyframeModels - removing the old ones.

However, grouped KeyframeModels will not be deleted until every model in
the group is finished. Since the incoming KeyframeModels have the same
group as the to-be-removed models, this doesn't happen until the new
models complete. However, some animations may never complete, leading to
unbounded growth.

This CL fixes the issue by setting the replaced group_id on a
KeyframeEffect performing this replacement. When the incoming keyframe
models are activated, the completed ones, matching the KeyframeEffect's
replaced group_id, have their group id removed. This allows them to be
deleted immediately and also prevents the model from dispatching a
finished event, since it's conceptually been "updated" rather than
deleted.

[1] https://source.chromium.org/chromium/chromium/src/+/main:cc/animation/keyframe_effect.cc;l=1024;drc=07bd1fe6394d0575e95b8211c872d851784f1d66

Change-Id: I5783b92285997a3a90cbb6563412f768f8978774
Bug: 323708859
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5300130
Reviewed-by: Robert Flack <flackr@chromium.org>
Commit-Queue: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1264266}
10 files changed
tree: 15042a7a6424dc380ddb10b194f86f514dcd0a19
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. webkit/
  51. .clang-format
  52. .clang-tidy
  53. .clangd
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitallowed
  57. .gitattributes
  58. .gitignore
  59. .gitmodules
  60. .gn
  61. .mailmap
  62. .rustfmt.toml
  63. .vpython3
  64. .yapfignore
  65. ATL_OWNERS
  66. AUTHORS
  67. BUILD.gn
  68. CODE_OF_CONDUCT.md
  69. codereview.settings
  70. DEPS
  71. DIR_METADATA
  72. LICENSE
  73. LICENSE.chromium_os
  74. OWNERS
  75. PRESUBMIT.py
  76. PRESUBMIT_test.py
  77. PRESUBMIT_test_mocks.py
  78. README.md
  79. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.