commit | 7e3b931bba397350885dd410546e3f3674eb01ac | [log] [tgz] |
---|---|---|
author | danakj <danakj@chromium.org> | Fri Feb 10 20:55:56 2023 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Fri Feb 10 20:55:56 2023 |
tree | c7d0db3f0631a3d3948f27073cdb90e9ff0ccfaf | |
parent | acf692011b14d653d1aa60b4342605df90a2661b [diff] |
Revert "Allow 64-bit offsets for raw_ptr arithmetic on 32-bit platforms" This reverts commit c6b9b6d69063366a8593b0c96434d5ab8ce7f162. Reason for revert: Introduces chance for signed integer overflow Original change's description: > Allow 64-bit offsets for raw_ptr arithmetic on 32-bit platforms > > BRP relies on operators +=/-=/+/- to verify that the new pointer doesn't > escape the allocation slot, otherwise ref-count of another slot may get > manipulated, leading to a byspass. Sadly, those operators were disabled > for 64-bit offsets on 32-bit platforms. > > Thanks tsepez@ for catching that! > > Change-Id: Ief813cb4ee2c6a10cb0ebc7e36348f16b577737c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4235831 > Reviewed-by: Tom Sepez <tsepez@chromium.org> > Commit-Queue: Tom Sepez <tsepez@chromium.org> > Auto-Submit: Bartek Nowierski <bartekn@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1103910} Change-Id: I24b270b491445f0a4d6433c7252910a41d8c249f No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4242039 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/main@{#1104036}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.