commit | 7e4619a28048a050d68f4fdbbf3db3043374fd29 | [log] [tgz] |
---|---|---|
author | Vaclav Brozek <vabr@chromium.org> | Mon Feb 11 10:15:31 2019 |
committer | Commit Bot <commit-bot@chromium.org> | Mon Feb 11 10:15:31 2019 |
tree | 384ba6e0ecbca39484807f30f6bda288d1a8f3c2 | |
parent | 44827fbd572669eb59878beb9b208e12bafd7813 [diff] |
CSVTable should only understand CRLF and LF as EOL So far, CSVTable understood any combination of CR and LF characters as the end of line. After a discussion linked to in https://crbug.com/923811, this CL changes that to explicitly only allowing CRLF and LF. Moreover, CRLF is no longer converted to LF inside quoted (escaped) strings. Performance impact, as measured with the benchmark from https://crrev.com/c/1459642: * Run time of the benchmark decreased from about 10s to about 9.5s * Peak memory consumption over 5 runs decreased from about 168700 kB to about 168350 kB Bug: 923811 Change-Id: I979d05e9f296f285db99dc22662bae29c907ea2a Reviewed-on: https://chromium-review.googlesource.com/c/1461042 Commit-Queue: Vaclav Brozek <vabr@chromium.org> Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#630708}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .