Reland "[TTFCC] Show credit cards in the bottom sheet"
This is a reland of commit 116ed391211a3dba4580a5726d0205c79617cee5
In the original CL I've removed the dependency on chrome_java.
It seemed unnecessary, but this error showed up in the CI:
Dependency Checks Failed
Target: //chrome/browser/touch_to_fill/payments/android/internal:javatests
Direct classpath is incomplete. To fix, add deps on:
* //chrome/android:chrome_java
* org.chromium.chrome.browser.ChromeTabbedActivity (needed by org.chromium.chrome.browser.touch_to_fill.payments.TouchToFillCreditCardViewTest)
* org.chromium.chrome.browser.ui.RootUiCoordinator (needed by org.chromium.chrome.browser.touch_to_fill.payments.TouchToFillCreditCardViewTest)
I've reproduced it locally for the configuration of the bot that failed and fixed it by adding a dependency to chrome_java to the suggested target. Since the target is only a test this fix is acceptable.
Original change's description:
> [TTFCC] Show credit cards in the bottom sheet
>
> From the bridge, the cards are passed further to the showSheet
> method of the TouchToFillCreditCardCoordinator which implements
> TouchToFillCreditCardComponent.
>
> The TouchToFillCreditCardCoordinator calls the showSheet method of the
> TouchToFillCreditCardMediator, which stores the credit cards as one of
> the TouchToFillCreditCardProperties.
>
> Changes to bind the views are made to TouchToFillCreditCardView and TouchToFillCreditCardViewBinder.
>
> The name of the card and the expiration date are already shown and the
> favicon will be added in a followup.
>
> HSV link to inspect the layout:
> https://hsv.googleplex.com/4905358175764480
>
> Screenshot with two cards:
> https://screenshot.googleplex.com/8BgSEpFi4Kn5M9k
>
> Bug: 1247698
> Change-Id: I4ffc976cae783183628828ef6b2f5d6fe2e967b2
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3963013
> Reviewed-by: Tanmoy Mollik <triploblastic@chromium.org>
> Reviewed-by: Matthias Körber <koerber@google.com>
> Commit-Queue: Ivana Žužić <izuzic@google.com>
> Reviewed-by: Friedrich Horschig <fhorschig@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1076217}
Bug: 1247698
Change-Id: Id46bb7fc0571c09d680abb9ba4c9a0efccb90a1a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4061461
Reviewed-by: Tanmoy Mollik <triploblastic@chromium.org>
Commit-Queue: Ivana Žužić <izuzic@google.com>
Reviewed-by: Friedrich Horschig <fhorschig@chromium.org>
Reviewed-by: Matthias Körber <koerber@google.com>
Cr-Commit-Position: refs/heads/main@{#1076880}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.